You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/27 10:40:56 UTC

[GitHub] [pulsar] Demogorgon314 opened a new pull request, #15815: [fix][test] Fix schema not found check on unit test

Demogorgon314 opened a new pull request, #15815:
URL: https://github.com/apache/pulsar/pull/15815

   ### Motivation
   
   After #12647, the schema not found exception message is replaced by `Schema not found`, so the `AdminApiSchemaValidationEnforced` test will always fail.
   ```
   java.lang.AssertionError: 
   Expected :true
   Actual   :false
   <Click to see difference>
   
   
     at org.testng.Assert.fail(Assert.java:99)
     at org.testng.Assert.failNotEquals(Assert.java:1037)
     at org.testng.Assert.assertTrue(Assert.java:45)
     at org.testng.Assert.assertTrue(Assert.java:55)
     at org.apache.pulsar.broker.admin.AdminApiSchemaValidationEnforced.testDisableSchemaValidationEnforcedHasSchema(AdminApiSchemaValidationEnforced.java:105)
   // ...
   ```
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1158751617

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 closed pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 closed pull request #15815: [fix][test] Fix schema not found check on unit test
URL: https://github.com/apache/pulsar/pull/15815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1157200276

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1190958890

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1140870543

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1272447674

   PR #17767 already fixed this issue, so I will close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1229150555

   @Demogorgon314 Please rebase to the master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1151937733

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1160042763

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1143242566

   It's an early PR, I'm wondering why could the CI still pass?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1152247184

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1272434589

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1141592766

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15815:
URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1148100758

   > It's an early PR, I'm wondering why could the CI still pass?
   
   Maybe because the test unit class name did not end with `Test`? After adding the `Test` suffix, it is running well in my local env.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org