You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by Yuxuan Wang <yu...@reddit.com.INVALID> on 2021/03/19 16:18:21 UTC

Can someone familiar with automake help review a PR?

https://github.com/apache/thrift/pull/2351

The go code part of that PR looks good now. But since it added a new
subdirectory under lib/go/test there are some automake changes (to
Makefile.am files) required. Some of the changes look different from the
existing Makefile.am code but I'm not familiar with automake to know if
those are bad or good.

Thanks!