You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/01/18 19:56:57 UTC

[spark] 01/01: [MINOR][HIVE] Pick up HIVE-22708 HTTP transport fix

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git

commit fbd95b1605dec0b3cd0577252b6635835604d7cf
Author: Sean Owen <sr...@gmail.com>
AuthorDate: Sat Jan 18 11:55:47 2020 -0800

    [MINOR][HIVE] Pick up HIVE-22708 HTTP transport fix
    
    Pick up the HTTP fix from https://issues.apache.org/jira/browse/HIVE-22708
    
    This is a small but important fix to digest handling we should pick up from Hive.
    
    No.
    
    Existing tests
    
    Closes #27273 from srowen/Hive22708.
    
    Authored-by: Sean Owen <sr...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .../src/main/java/org/apache/hive/service/CookieSigner.java             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/CookieSigner.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/CookieSigner.java
index ee51c24..f2a80c9 100644
--- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/CookieSigner.java
+++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/CookieSigner.java
@@ -81,7 +81,7 @@ public class CookieSigner {
     if (LOG.isDebugEnabled()) {
       LOG.debug("Signature generated for " + rawValue + " inside verify is " + currentSignature);
     }
-    if (!originalSignature.equals(currentSignature)) {
+    if (!MessageDigest.isEqual(originalSignature.getBytes(), currentSignature.getBytes())) {
       throw new IllegalArgumentException("Invalid sign, original = " + originalSignature +
         " current = " + currentSignature);
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org