You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michael Watzek (JIRA)" <ji...@apache.org> on 2006/03/29 18:36:30 UTC

[jira] Created: (JDO-355) Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.

Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.
-----------------------------------------------------------------------

         Key: JDO-355
         URL: http://issues.apache.org/jira/browse/JDO-355
     Project: JDO
        Type: Improvement
  Components: tck20  
    Versions: JDO 2 rc1    
    Reporter: Michael Watzek
 Assigned to: Michael Watzek 
    Priority: Minor
     Fix For: JDO 2 final


I noticed that there is a little mismatch between test case MakePersistent, the .sql files, and the .orm files for mappings 5, 6, 7 wrt. which persistence capable classes are needed:

- Test case MakePersistent uses pc class PCPoint only.
- The .sql files create tables PCPoint and PCRect.
- The .orm files specifiy metadata for pc classes PCPoint, PCPoint2, PCRect, and PrimitiveTypes.

This holds true for application identity and datastore identity as well. 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JDO-355) Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-355?page=all ]

Michael Bouschen updated JDO-355:
---------------------------------

    Attachment: JDO-355.patch

The attached patch (JDO-355.patch) removes PCRect from the .sql files and PCPoint2, PCRect, and PrimitiveTypes from .orm files for both applicationidentity and datastoreidentity. I just started maven clean build to make sure that the patch does not break anything.  

> Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.
> -----------------------------------------------------------------------
>
>          Key: JDO-355
>          URL: http://issues.apache.org/jira/browse/JDO-355
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Versions: JDO 2 rc1
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>     Priority: Minor
>      Fix For: JDO 2 final
>  Attachments: JDO-355.patch
>
> I noticed that there is a little mismatch between test case MakePersistent, the .sql files, and the .orm files for mappings 5, 6, 7 wrt. which persistence capable classes are needed:
> - Test case MakePersistent uses pc class PCPoint only.
> - The .sql files create tables PCPoint and PCRect.
> - The .orm files specifiy metadata for pc classes PCPoint, PCPoint2, PCRect, and PrimitiveTypes.
> This holds true for application identity and datastore identity as well. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (JDO-355) Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JDO-355?page=comments#action_12372279 ] 

Craig Russell commented on JDO-355:
-----------------------------------

When the tests were written, I think we didn't know exactly what we were going to test, and made extra classes persistent in order to have some flexibility. 

Now that the tests are complete, it's not clear to me that we will ever extend the test cases so we don't need to keep the extra classes in the sql and orm. 

So it's ok with me to remove the extras.

> Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.
> -----------------------------------------------------------------------
>
>          Key: JDO-355
>          URL: http://issues.apache.org/jira/browse/JDO-355
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Versions: JDO 2 rc1
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>     Priority: Minor
>      Fix For: JDO 2 final

>
> I noticed that there is a little mismatch between test case MakePersistent, the .sql files, and the .orm files for mappings 5, 6, 7 wrt. which persistence capable classes are needed:
> - Test case MakePersistent uses pc class PCPoint only.
> - The .sql files create tables PCPoint and PCRect.
> - The .orm files specifiy metadata for pc classes PCPoint, PCPoint2, PCRect, and PrimitiveTypes.
> This holds true for application identity and datastore identity as well. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (JDO-355) Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-355?page=all ]
     
Michael Bouschen resolved JDO-355:
----------------------------------

    Resolution: Fixed
     Assign To: Michael Bouschen  (was: Michael Watzek)

I checked in the patch.

Sende          tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard5.orm
Sende          tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard6.orm
Sende          tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard7.orm
Sende          tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard5.orm
Sende          tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard6.orm
Sende          tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard7.orm
Sende          tck20\src\sql\derby\applicationidentity\schema5.sql
Sende          tck20\src\sql\derby\applicationidentity\schema6.sql
Sende          tck20\src\sql\derby\applicationidentity\schema7.sql
Sende          tck20\src\sql\derby\datastoreidentity\schema5.sql
Sende          tck20\src\sql\derby\datastoreidentity\schema6.sql
Sende          tck20\src\sql\derby\datastoreidentity\schema7.sql
?\195?\156bertrage Daten ............
Revision 389850 ?\195?\188bertragen.


> Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.
> -----------------------------------------------------------------------
>
>          Key: JDO-355
>          URL: http://issues.apache.org/jira/browse/JDO-355
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Versions: JDO 2 rc1
>     Reporter: Michael Watzek
>     Assignee: Michael Bouschen
>     Priority: Minor
>      Fix For: JDO 2 final
>  Attachments: JDO-355.patch
>
> I noticed that there is a little mismatch between test case MakePersistent, the .sql files, and the .orm files for mappings 5, 6, 7 wrt. which persistence capable classes are needed:
> - Test case MakePersistent uses pc class PCPoint only.
> - The .sql files create tables PCPoint and PCRect.
> - The .orm files specifiy metadata for pc classes PCPoint, PCPoint2, PCRect, and PrimitiveTypes.
> This holds true for application identity and datastore identity as well. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira