You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/07/18 20:03:15 UTC

Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/
-----------------------------------------------------------

Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.


Bugs: AMBARI-6534
    https://issues.apache.org/jira/browse/AMBARI-6534


Repository: ambari


Description
-------

During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
  ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
  ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 

Diff: https://reviews.apache.org/r/23690/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [7.032s]
[INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
[INFO] Ambari Agent ...................................... SUCCESS [4.772s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:28.464s
[INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
[INFO] Final Memory: 22M/243M
[INFO] ------------------------------------------------------------------------
 


Thanks,

Dmitro Lisnichenko

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 3 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java, lines 165-166
> > <https://reviews.apache.org/r/23690/diff/1/?file=635661#file635661line165>
> >
> >     addAll() will throw a NPE if convertAlerts fails.

Agree, it possible. I'll fix it


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48228
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 3 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java, lines 165-166
> > <https://reviews.apache.org/r/23690/diff/1/?file=635661#file635661line165>
> >
> >     addAll() will throw a NPE if convertAlerts fails.
> 
> Dmytro Shkvyra wrote:
>     Agree, it possible. I'll fix it

Nate, I have fixed it. convertAlerts will return empty list if AmbariException occured.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48228
-----------------------------------------------------------


On July 21, 2014, 5:06 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 5:06 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d216aea 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48228
-----------------------------------------------------------


You must confirm these alerts are getting sent to Nagios.  Where is the Nagios definition for host disk space done?


ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java
<https://reviews.apache.org/r/23690/#comment84582>

    addAll() will throw a NPE if convertAlerts fails.


- Nate Cole


On July 18, 2014, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 2:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48357
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On July 21, 2014, 5:06 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 5:06 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d216aea 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48493
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On July 21, 2014, 1:06 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 1:06 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d216aea 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/
-----------------------------------------------------------

(Updated July 21, 2014, 5:06 p.m.)


Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.


Changes
-------

Changes:
Prevention of NPE if we passed wrong passed wrong cluster name (very rare situation, fixed accordingly Thomas Beerbower's comment) 


Bugs: AMBARI-6534
    https://issues.apache.org/jira/browse/AMBARI-6534


Repository: ambari


Description
-------

During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
  ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d216aea 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
  ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 

Diff: https://reviews.apache.org/r/23690/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [7.032s]
[INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
[INFO] Ambari Agent ...................................... SUCCESS [4.772s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:28.464s
[INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
[INFO] Final Memory: 22M/243M
[INFO] ------------------------------------------------------------------------
 


Thanks,

Dmitro Lisnichenko

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 2:58 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java, lines 55-56
> > <https://reviews.apache.org/r/23690/diff/1/?file=635662#file635662line55>
> >
> >     Is this required?  If not can you remove it?

Yes Tom, we should have default constructor for deserialization.
 


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48227
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Tom Beerbower <tb...@hortonworks.com>.

> On July 21, 2014, 2:58 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java, lines 55-56
> > <https://reviews.apache.org/r/23690/diff/1/?file=635662#file635662line55>
> >
> >     Is this required?  If not can you remove it?
> 
> Dmytro Shkvyra wrote:
>     Yes Tom, we should have default constructor for deserialization.
>

I guess I'm asking if there is a reason that you have to explicitly specify it?  Wouldn't the implicit default constructor be the same?


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48227
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 2:58 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java, lines 55-56
> > <https://reviews.apache.org/r/23690/diff/1/?file=635662#file635662line55>
> >
> >     Is this required?  If not can you remove it?
> 
> Dmytro Shkvyra wrote:
>     Yes Tom, we should have default constructor for deserialization.
>
> 
> Tom Beerbower wrote:
>     I guess I'm asking if there is a reason that you have to explicitly specify it?  Wouldn't the implicit default constructor be the same?

Tom, it will not work without it. :)


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48227
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Tom Beerbower <tb...@hortonworks.com>.

> On July 21, 2014, 2:58 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java, lines 55-56
> > <https://reviews.apache.org/r/23690/diff/1/?file=635662#file635662line55>
> >
> >     Is this required?  If not can you remove it?
> 
> Dmytro Shkvyra wrote:
>     Yes Tom, we should have default constructor for deserialization.
>
> 
> Tom Beerbower wrote:
>     I guess I'm asking if there is a reason that you have to explicitly specify it?  Wouldn't the implicit default constructor be the same?
> 
> Dmytro Shkvyra wrote:
>     Tom, it will not work without it. :)

Ah, I see now.  With the diff tool, I didn't see that there was also a custom constructor. Thanks.


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48227
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48227
-----------------------------------------------------------

Ship it!


Looks good.  Could you have Nate Cole take a look also?


ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java
<https://reviews.apache.org/r/23690/#comment84581>

    Is this required?  If not can you remove it?


- Tom Beerbower


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 3:04 p.m., Nate Cole wrote:
> > Why isn't any of this returned with HostInfo and use that information straight out of Ambari?  Why add all this extra work on the agent to get the disk usage info when it should be part of HostInfo.
> 
> Dmytro Shkvyra wrote:
>     Because we also need have info about directories. This info is a part of AgentEnv, but agent send it to server once, when register. So, we have outdated information and we cant create alert for directories and mountpoints which were added after agent register. Also, creation of alerts on agent spillout load among hosts. In case, if we create alerts on server for 2k cluster we can have low performance.
> 
> Nate Cole wrote:
>     Code that loads agentEnv happens every 6th heartbeat, around once per minute.

I have checked it. agentEnv loaded only once.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48230
-----------------------------------------------------------


On July 21, 2014, 5:06 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 5:06 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d216aea 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Nate Cole <nc...@hortonworks.com>.

> On July 21, 2014, 11:04 a.m., Nate Cole wrote:
> > Why isn't any of this returned with HostInfo and use that information straight out of Ambari?  Why add all this extra work on the agent to get the disk usage info when it should be part of HostInfo.
> 
> Dmytro Shkvyra wrote:
>     Because we also need have info about directories. This info is a part of AgentEnv, but agent send it to server once, when register. So, we have outdated information and we cant create alert for directories and mountpoints which were added after agent register. Also, creation of alerts on agent spillout load among hosts. In case, if we create alerts on server for 2k cluster we can have low performance.

Code that loads agentEnv happens every 6th heartbeat, around once per minute.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48230
-----------------------------------------------------------


On July 21, 2014, 1:06 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 1:06 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d216aea 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 3:04 p.m., Nate Cole wrote:
> > Why isn't any of this returned with HostInfo and use that information straight out of Ambari?  Why add all this extra work on the agent to get the disk usage info when it should be part of HostInfo.

Because we also need have info about directories. This info is a part of AgentEnv, but agent send it to server once, when register. So, we have outdated information and we cant create alert for directories and mountpoints which were added after agent register. Also, creation of alerts on agent spillout load among hosts. In case, if we create alerts on server for 2k cluster we can have low performance.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48230
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48230
-----------------------------------------------------------


Why isn't any of this returned with HostInfo and use that information straight out of Ambari?  Why add all this extra work on the agent to get the disk usage info when it should be part of HostInfo.

- Nate Cole


On July 18, 2014, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 2:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Nate Cole <nc...@hortonworks.com>.

> On July 21, 2014, 11:02 a.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/HostInfo.py, lines 242-247
> > <https://reviews.apache.org/r/23690/diff/1/?file=635655#file635655line242>
> >
> >     Comment indicates this is configurable.  How?
> 
> Dmytro Shkvyra wrote:
>     What did you mean? Which comment?

"they fill up beyond a threshold like 80% (configurable)."  Sorry, I meant description - not comment :)


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48229
-----------------------------------------------------------


On July 18, 2014, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 2:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 3:02 p.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/HostInfo.py, lines 242-247
> > <https://reviews.apache.org/r/23690/diff/1/?file=635655#file635655line242>
> >
> >     Comment indicates this is configurable.  How?
> 
> Dmytro Shkvyra wrote:
>     What did you mean? Which comment?
> 
> Nate Cole wrote:
>     "they fill up beyond a threshold like 80% (configurable)."  Sorry, I meant description - not comment :)

Sorry, I have asked clarification for details, but got nothing. :( I really have no ideas how it will be configured. I think we should discuss it more wide. I need more info about remote configutation of agent. 


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48229
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 3:02 p.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/HostInfo.py, lines 242-247
> > <https://reviews.apache.org/r/23690/diff/1/?file=635655#file635655line242>
> >
> >     Comment indicates this is configurable.  How?

What did you mean? Which comment?


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48229
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On July 21, 2014, 3:02 p.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/HostInfo.py, lines 242-247
> > <https://reviews.apache.org/r/23690/diff/1/?file=635655#file635655line242>
> >
> >     Comment indicates this is configurable.  How?
> 
> Dmytro Shkvyra wrote:
>     What did you mean? Which comment?
> 
> Nate Cole wrote:
>     "they fill up beyond a threshold like 80% (configurable)."  Sorry, I meant description - not comment :)
> 
> Dmytro Shkvyra wrote:
>     Sorry, I have asked clarification for details, but got nothing. :( I really have no ideas how it will be configured. I think we should discuss it more wide. I need more info about remote configutation of agent.
> 
> Nate Cole wrote:
>     Ok.  Agent configuration usually comes out of ambari-agent.ini.  In theory you could put the value there in an appropriate section/key.

I have thought about this, but somebody should change this property on all agent's hosts. If we talk about 2k cluster... In my opinion it is not convinient completely. We should have a mechanism of remote configuring. Now we have custom commands, but they related to components, not with agent.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48229
-----------------------------------------------------------


On July 21, 2014, 5:06 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 5:06 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d216aea 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Nate Cole <nc...@hortonworks.com>.

> On July 21, 2014, 11:02 a.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/HostInfo.py, lines 242-247
> > <https://reviews.apache.org/r/23690/diff/1/?file=635655#file635655line242>
> >
> >     Comment indicates this is configurable.  How?
> 
> Dmytro Shkvyra wrote:
>     What did you mean? Which comment?
> 
> Nate Cole wrote:
>     "they fill up beyond a threshold like 80% (configurable)."  Sorry, I meant description - not comment :)
> 
> Dmytro Shkvyra wrote:
>     Sorry, I have asked clarification for details, but got nothing. :( I really have no ideas how it will be configured. I think we should discuss it more wide. I need more info about remote configutation of agent.

Ok.  Agent configuration usually comes out of ambari-agent.ini.  In theory you could put the value there in an appropriate section/key.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48229
-----------------------------------------------------------


On July 21, 2014, 1:06 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 1:06 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d216aea 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48229
-----------------------------------------------------------



ambari-agent/src/main/python/ambari_agent/HostInfo.py
<https://reviews.apache.org/r/23690/#comment84583>

    Comment indicates this is configurable.  How?


- Nate Cole


On July 18, 2014, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 2:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48214
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>