You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/08/23 23:00:10 UTC
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11311
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
[cmake] add OpenSSL include path into -isystem
Prior to this change, when cmake package is installed under the same
prefix as boost package (e.g. /opt/local on OS X if using MacPorts),
running cmake will choose the thirdparty-built boost, but due to the
intermix of '-isystem' and '-I' options, the '-I' path wins when running
the compiler. I.e., the path specific with '-I' option is chosen over
the path specified with the '-isystem' option if the latter comes first
in the command line. That could lead to mysterious compilation errors.
This patch puts the OpenSSL's include path into the -isystem
category along with other third-party libraries used by Kudu. Aside
from resolving the inconsistency mentioned above, this makes the usage
of the angle brackets vs quotes in #include statement to be in sync with
the way how OpenSSL headers are included into the Kudu source files.
Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11311/1
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 )
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11311/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11311/1//COMMIT_MSG@13
PS1, Line 13: the compiler. I.e., the path specific with '-I' option is chosen over
specified
http://gerrit.cloudera.org:8080/#/c/11311/1//COMMIT_MSG@15
PS1, Line 15: in the command line. That could lead to mysterious compilation errors.
So the compilation errors you saw were regarding boost? Or openssl? If the former, how does changing openssl's inclusion help?
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 23:05:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 )
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 23:35:47 +0000
Gerrit-HasComments: No
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 )
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11311/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11311/1//COMMIT_MSG@15
PS1, Line 15: in the command line. That could lead to mysterious compilation errors.
> So the compilation errors you saw were regarding boost? Or openssl? If the
The compilation errors were related to boost.
It seems I'm not good at explaining things clearly, my bad :)
Try the things below, and I'll try to update the message meanwhile.
cd /tmp
mkdir -p a
mkdir -p b
cat << EOF > x.cc
#include <iostream>
#include <inc.h>
using namespace std;
int main() {
cout << sizeof(A) << endl;
return 0;
}
EOF
cat << EOF > a/inc.h
struct A {
int f0;
};
EOF
cat << EOF > b/inc.h
struct A {
int f0;
long f1;
double f2;
};
EOF
c++ -isystem ./a -I ./b x.cc && ./a.out
c++ -isystem ./a -isystem ./b x.cc && ./a.out
c++ -isystem ./b -I ./a x.cc && ./a.out
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 23:22:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 )
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11311/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11311/1//COMMIT_MSG@9
PS1, Line 9: cmake
Woops, that's the typo, sorry. It should be 'OpenSSL'
http://gerrit.cloudera.org:8080/#/c/11311/1//COMMIT_MSG@13
PS1, Line 13: the compiler. I.e., the path specific with '-I' option is chosen over
> specified
Done
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 23:31:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11311 )
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
[cmake] add OpenSSL include path into -isystem
Prior to this change, when OpenSSL package is installed under the same
prefix as boost package (e.g. /opt/local on OS X if using MacPorts),
running cmake will choose the thirdparty-built boost, but due to the
intermix of '-isystem' and '-I' options, the '-I' path wins when running
the compiler. I.e., the path specified with the '-I' option is chosen
over the path specified with the '-isystem' option if the latter comes
first in the command line. That could lead to mysterious compilation
errors if the version and features of the OS-packaged boost library
differ from those compiled under $KUDU_HOME/thirdparty.
This patch puts the OpenSSL's include path into the -isystem
category along with other third-party libraries used by Kudu. Aside
from resolving the inconsistency mentioned above, this makes the usage
of the angle brackets vs quotes in #include statement to be in sync with
the way how OpenSSL headers are included into the Kudu source files.
Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Reviewed-on: http://gerrit.cloudera.org:8080/11311
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11311 )
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 )
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
Patch Set 2: Verified+1
Unrelated flake in:
org.apache.kudu.spark.kudu.DefaultSourceTest.testSocketReadTimeoutPropagation
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Aug 2018 00:41:55 +0000
Gerrit-HasComments: No
[kudu-CR] [cmake] add OpenSSL include path into -isystem
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11311
to look at the new patch set (#2).
Change subject: [cmake] add OpenSSL include path into -isystem
......................................................................
[cmake] add OpenSSL include path into -isystem
Prior to this change, when OpenSSL package is installed under the same
prefix as boost package (e.g. /opt/local on OS X if using MacPorts),
running cmake will choose the thirdparty-built boost, but due to the
intermix of '-isystem' and '-I' options, the '-I' path wins when running
the compiler. I.e., the path specified with the '-I' option is chosen
over the path specified with the '-isystem' option if the latter comes
first in the command line. That could lead to mysterious compilation
errors if the version and features of the OS-packaged boost library
differ from those compiled under $KUDU_HOME/thirdparty.
This patch puts the OpenSSL's include path into the -isystem
category along with other third-party libraries used by Kudu. Aside
from resolving the inconsistency mentioned above, this makes the usage
of the angle brackets vs quotes in #include statement to be in sync with
the way how OpenSSL headers are included into the Kudu source files.
Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11311/2
--
To view, visit http://gerrit.cloudera.org:8080/11311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3
Gerrit-Change-Number: 11311
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins