[GitHub] [hbase] vli02 commented on a change in pull request #3308: HBASE-25910 - Fix port assignment test

[GitBox <gi...@apache.org>]

vli02 commented on a change in pull request #3308:
URL: https://github.com/apache/hbase/pull/3308#discussion_r639992175



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java
##########
@@ -44,16 +46,20 @@
   @Test
   public void testClusterPortAssignment() throws Exception {
     boolean retry = false;
+    int retryCount = 0;
     do {
       int masterPort =  HBaseTestingUtility.randomFreePort();
       int masterInfoPort =  HBaseTestingUtility.randomFreePort();
       int rsPort =  HBaseTestingUtility.randomFreePort();
       int rsInfoPort =  HBaseTestingUtility.randomFreePort();
       TEST_UTIL.getConfiguration().setBoolean(LocalHBaseCluster.ASSIGN_RANDOM_PORTS, false);
+      TEST_UTIL.getConfiguration().setBoolean(HConstants.REGIONSERVER_INFO_PORT_AUTO, false);
+      TEST_UTIL.getConfiguration().setBoolean("fs.hdfs.impl.disable.cache", true);

Review comment:
       Maybe. The restart failure happens here: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java#L207
   
   I guess previous shutdown in the same jvm has left anything for hdfs to do in cache.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org