You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/25 23:22:11 UTC
[GitHub] [calcite] ieugen opened a new pull request #2660: Fix CALCITE-4966 - make CsvEnumerator.RowConverter public
ieugen opened a new pull request #2660:
URL: https://github.com/apache/calcite/pull/2660
CsvEnumerator.RowConverter is exposed in consturctor and public static method so it should be public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] ieugen commented on pull request #2660: [CALCITE-4966] Make CsvEnumerator.RowConverter public
Posted by GitBox <gi...@apache.org>.
ieugen commented on pull request #2660:
URL: https://github.com/apache/calcite/pull/2660#issuecomment-1001162306
@NobiGo : Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] NobiGo commented on pull request #2660: Fix CALCITE-4966 - make CsvEnumerator.RowConverter public
Posted by GitBox <gi...@apache.org>.
NobiGo commented on pull request #2660:
URL: https://github.com/apache/calcite/pull/2660#issuecomment-1001093712
Please reformat the commit info like
`[CALCITE-345] AssertionError in RexToLixTranslator comparing to date literal`
Then the PR can auto-link to JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] ieugen edited a comment on pull request #2660: Fix CALCITE-4966 - make CsvEnumerator.RowConverter public
Posted by GitBox <gi...@apache.org>.
ieugen edited a comment on pull request #2660:
URL: https://github.com/apache/calcite/pull/2660#issuecomment-1001161123
@NobiGo : As long as the jira ID is in the commit log, it will work.
It does work now.
I will change the commit text as you mentioned and force push the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] ieugen commented on pull request #2660: Fix CALCITE-4966 - make CsvEnumerator.RowConverter public
Posted by GitBox <gi...@apache.org>.
ieugen commented on pull request #2660:
URL: https://github.com/apache/calcite/pull/2660#issuecomment-1001161123
@NobiGo : As long as the jira ID is in the commit log, it will work.
It does work now.
I will change the commit id as you mentioned and force push the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org