You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2016/12/20 21:40:10 UTC
Review Request 54913: Added some missing log statements for scheduler
calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54913/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
Some Scheduler API calls ('KILL'/'SHUTDOWN') were missing info
level logging statements. In the case of `KILL', the logging
statement was there but was invoked in `killTask()` that is
no longer used by the scheduler driver.
Diffs
-----
src/master/master.cpp b664550d57ef9805bd23ea35ca7f9cd8f4b1ab78
Diff: https://reviews.apache.org/r/54913/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 54913: Added some missing log statements for
scheduler calls.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54913/#review159756
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp (line 4697)
<https://reviews.apache.org/r/54913/#comment230805>
You can stream the `taskId` from above.
Please double check on the single quotes.
src/master/master.cpp (line 5947)
<https://reviews.apache.org/r/54913/#comment230806>
Please double check the quotes here as well.
- Joris Van Remoortere
On Dec. 20, 2016, 9:40 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54913/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 9:40 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some Scheduler API calls ('KILL'/'SHUTDOWN') were missing info
> level logging statements. In the case of `KILL', the logging
> statement was there but was invoked in `killTask()` that is
> no longer used by the scheduler driver.
>
>
> Diffs
> -----
>
> src/master/master.cpp b664550d57ef9805bd23ea35ca7f9cd8f4b1ab78
>
> Diff: https://reviews.apache.org/r/54913/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 54913: Added some missing log statements for
scheduler calls.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54913/
-----------------------------------------------------------
(Updated Dec. 20, 2016, 11:09 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Review comments, NNFR
Repository: mesos
Description (updated)
-------
Some Scheduler API calls ('KILL'/'SHUTDOWN') were missing info
level logging statements. In the case of `KILL', the logging
statement was there but was invoked in `killTask()` but was
not consistent with how we were logging for the other calls
in the continuation helper.
Diffs (updated)
-----
src/master/master.cpp b664550d57ef9805bd23ea35ca7f9cd8f4b1ab78
Diff: https://reviews.apache.org/r/54913/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar