You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "ngsg (via GitHub)" <gi...@apache.org> on 2024/08/30 05:50:49 UTC
[PR] [WIP] HIVE-28490: Stop removing retainable DPP sources [hive]
ngsg opened a new pull request, #5425:
URL: https://github.com/apache/hive/pull/5425
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch changes the implementation of SharedWorkOptimizer#findAscendantWorkOperators. For a given operator, original findAscendantWorkOperators() returns a set of operators that belongs to ancestor vertices of the vertex that given operator belongs to. Therefore, some operators that are irrelevant to the given operator also belong to the resultant set, which leads to wrong DPP source removal. The new implementation returns a set of ancestor operators of the given operator.
Please check out the slides attached in the JIRA page (HIVE-24890) for further explanations.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In order to prevent the removal of retainable DPP sources that are still useful in runtime.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### Is the change a dependency upgrade?
<!--
If yes, please attach a file with output from mvn dependency:tree to validate a complete upgrade of dependency.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
We tested this patch by running all TPC-DS queries in cluster. This patch contains a qfile test that reproduces the wrong DPP source removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819110312
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
Review Comment:
should we ignore `ReduceSinkOperator` parents (see findWorkOperators(..))?
````
if (parent instanceof ReduceSinkOperator) {
continue;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5425:
URL: https://github.com/apache/hive/pull/5425#issuecomment-2320339346
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5425) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5425&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5425&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5425&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5425&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5425&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5425)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1818994330
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
+ if (op instanceof TableScanOperator) {
+ remaining.addAll(optimizerCache.tableScanToDPPSource.get((TableScanOperator) op));
}
}
- workOps = set;
- result.addAll(set);
}
- return result;
+
+ return visited;
}
private static Set<Operator<?>> findChildWorkOperators(ParseContext pctx,
Review Comment:
can we drop it since it's not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819117243
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
Review Comment:
do I understand it right that `findAscendantWorkOperators` collects recursively both parents and children starting from `start` and here we only need parent operators?
Note `findWorkOperators` leverages the cache, do we need the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819117243
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
Review Comment:
do I understand it right that `findAscendantWorkOperators` collects recursively both parents and children starting from `start` and here we only need parent operators?
Note `findWorkOperators` leverages the cache, do we need the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819106985
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
Review Comment:
can `op` be NULL (op.getParentOperators()) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1818964179
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
Review Comment:
maybe use `Queue<Operator<?>> remaining = new LinkedList<>()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5425:
URL: https://github.com/apache/hive/pull/5425#issuecomment-2443284661
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5425) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5425&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5425&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5425&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5425&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5425&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5425)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1818964991
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
+ if (op instanceof TableScanOperator) {
Review Comment:
please restore removed comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on PR #5425:
URL: https://github.com/apache/hive/pull/5425#issuecomment-2323577313
@BsoBird , thanks for pointing out the typo. I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #5425:
URL: https://github.com/apache/hive/pull/5425#issuecomment-2443521603
@ramesh0201, @kasakrisz, could you please take a look at this PR as a second pair of eyes? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819268439
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
Review Comment:
do I understand it right that original `findWorkOperators` collects recursively both operator's parents and children starting from `start`
````
{MAPJOIN_217, SEL_27, GBY_29, SEL_140, GBY_141, RS_142,
SEL_185, GBY_186, RS_187}
````
but we only interested in parents
````
{MAPJOIN_217, SEL_27, GBY_29, SEL_185, GBY_186, RS_187}
````
?
Note `findWorkOperators` leverages the cache, do we need the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1818995481
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
+ if (op instanceof TableScanOperator) {
+ remaining.addAll(optimizerCache.tableScanToDPPSource.get((TableScanOperator) op));
}
}
- workOps = set;
- result.addAll(set);
}
- return result;
+
+ return visited;
}
private static Set<Operator<?>> findChildWorkOperators(ParseContext pctx,
Review Comment:
same for `findParentWorkOperators`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819110312
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
Review Comment:
should we ignore `ReduceSinkOperator` parents (see findWorkOperators(..))?
````
if (parent instanceof ReduceSinkOperator) {
continue;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819262472
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
Review Comment:
can we get NULL from `op.getParentOperators()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819268439
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
Review Comment:
do I understand it right that original `findWorkOperators` collects recursively both operator's parents and children starting from `start`, but we only interested in parents?
Note findWorkOperators leverages the cache, do we need the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819277783
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
Review Comment:
do we have similar issue in `findParentWorkOperators`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1820079021
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
+ if (op instanceof TableScanOperator) {
Review Comment:
restored the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1820078760
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
Review Comment:
changed to use Queue and LinkedList
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ merged PR #5425:
URL: https://github.com/apache/hive/pull/5425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819110312
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
Review Comment:
should we ignore `ReduceSinkOperator` parents?
````
if (parent instanceof ReduceSinkOperator) {
continue;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1820302834
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
Review Comment:
👍 , thanks for the explanation @ngsg!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #5425:
URL: https://github.com/apache/hive/pull/5425#issuecomment-2441923672
thanks for the fix @ngsg! sorry for the late reply. I've added a few comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819268439
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
Review Comment:
do I understand it right that original `findWorkOperators` collects recursively both operator's parents and children starting from `start`
````{MAPJOIN_217, SEL_27, GBY_29, SEL_140, GBY_141, RS_142,
SEL_185, GBY_186, RS_187}````
, but we only interested in parents
````{MAPJOIN_217, SEL_27, GBY_29, SEL_185, GBY_186, RS_187}````
?
Note findWorkOperators leverages the cache, do we need the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819106985
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
Review Comment:
can `op` be NULL (op.getParentOperators()) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1820080023
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
Review Comment:
Yes. Changed to do null-check before add `op.getParentOperators()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #5425:
URL: https://github.com/apache/hive/pull/5425#issuecomment-2485463074
ok, since there were no other reviews, I am merging this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5425:
URL: https://github.com/apache/hive/pull/5425#issuecomment-2460479817
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5425) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5425&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5425&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5425&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5425&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5425&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5425)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "BsoBird (via GitHub)" <gi...@apache.org>.
BsoBird commented on PR #5425:
URL: https://github.com/apache/hive/pull/5425#issuecomment-2320681853
tips: HIVE-24890 => HIVE-28490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1818964179
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
Review Comment:
maybe use Queue<Operator<?>> remaining = new LinkedList<>()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819117243
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
Review Comment:
do I understand it right that `findWorkOperators` collects recursively both parents and children starting from `start` and here we only need parent operators?
Note `findWorkOperators` leverages the cache, do we need the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1819268439
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
Review Comment:
do I understand it right that original `findWorkOperators` collects recursively both operator's parents and children starting from `start`
````
{MAPJOIN_217, SEL_27, GBY_29, SEL_140, GBY_141, RS_142,
SEL_185, GBY_186, RS_187}
````
but we only interested in parents
````
{MAPJOIN_217, SEL_27, GBY_29, SEL_185, GBY_186, RS_187}
````
?
Note findWorkOperators leverages the cache, do we need the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1820079419
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
+ Operator<?> start) {
+ Set<Operator<?>> visited = new HashSet<>();
+ visited.add(start);
+
+ List<Operator<?>> remaining = new ArrayList<>(start.getParentOperators());
+ while (!remaining.isEmpty()) {
+ Operator<?> op = remaining.remove(0);
+ if (!visited.contains(op)) {
+ visited.add(op);
+ remaining.addAll(op.getParentOperators());
+ if (op instanceof TableScanOperator) {
+ remaining.addAll(optimizerCache.tableScanToDPPSource.get((TableScanOperator) op));
}
}
- workOps = set;
- result.addAll(set);
}
- return result;
+
+ return visited;
}
private static Set<Operator<?>> findChildWorkOperators(ParseContext pctx,
Review Comment:
Yes, we can. Removed `findChildWorkOperators` and `findParentWorkOperators` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28490: Stop removing retainable DPP sources [hive]
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on code in PR #5425:
URL: https://github.com/apache/hive/pull/5425#discussion_r1820101433
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1963,33 +1962,24 @@ private static Set<Operator<?>> findParentWorkOperators(ParseContext pctx,
return set;
}
- private static Set<Operator<?>> findAscendantWorkOperators(ParseContext pctx,
- SharedWorkOptimizerCache optimizerCache, Operator<?> start) {
- // Find operators in work
- Set<Operator<?>> workOps = findWorkOperators(optimizerCache, start);
- // Gather input works operators
- Set<Operator<?>> result = new HashSet<Operator<?>>();
- Set<Operator<?>> set;
- while (!workOps.isEmpty()) {
- set = new HashSet<Operator<?>>();
- for (Operator<?> op : workOps) {
- if (op.getParentOperators() != null) {
- for (Operator<?> parent : op.getParentOperators()) {
- if (parent instanceof ReduceSinkOperator) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
- }
- } else if (op instanceof TableScanOperator) {
- // Check for DPP and semijoin DPP
- for (Operator<?> parent : optimizerCache.tableScanToDPPSource.get((TableScanOperator) op)) {
- set.addAll(findWorkOperators(optimizerCache, parent));
- }
+ private static Set<Operator<?>> findAscendantWorkOperators(SharedWorkOptimizerCache optimizerCache,
Review Comment:
1 .
Yes, `findWorkOperators` returns the set of operators that will be packed in to the same work (`Vertex` in Tez and `BaseWork` in Hive).
Using `findWorkOperators`, we can compute the set of operators that belongs to the same work or its ancestor work. But this set is not our interest because the dependency between works does not always imply the dependency between operators.
For example, we can find 5 works from the below operator graph. (The same as the one in the slide)
```
Work1: MAPJOIN_217, SEL_27, GBY_29, SEL_140, GBY_141, RS_142, SEL_185, GBY_186, RS_187
Work2: GBY_143, RS_144
Work3: TS_3, FIL_116
Work4: GBY_188, RS_189
Work5: TS_41, FIL_121
```
In the example, RS_189 belongs to Work4, which depends on Work1. But RS_189 does not depend on RS_142, which is a member of Work1.
2 .
Since **the set of ascendant operators** is used less frequently than **the set of operators that belong to the same work**, I think we don't need another cache that is dedicated to `findAscendantWorkOperators`.
3 .
We don't use `findParentWorkOperators` anymore, and I don't know its original usage. Since findParentWorkOperators is just a one-step version of findAscendantWorkOperators, there might be the same issue if one used this method to find any dependency conflicts between operators.
4 .
I have changed the name of the method to `findAscendantOperators` as the method does not use the concept of work here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org