You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "crystalxyz (via GitHub)" <gi...@apache.org> on 2025/10/23 17:04:17 UTC
[PR] feat: Allow dynamic filter pushdown to handle both left and right sides to be the probe side [datafusion]
crystalxyz opened a new pull request, #18247:
URL: https://github.com/apache/datafusion/pull/18247
## Which issue does this PR close?
- Part of a series of PRs for #16973.
- Built upon #17518 with little refactoring
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Allow dynamic filter pushdown to handle both left and right sides to be the probe side [datafusion]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on PR #18247:
URL: https://github.com/apache/datafusion/pull/18247#issuecomment-3438722208
I may be wrong here, but I believe hash join exec creates any dynamic filters any swapping, so the right side will always be the probe side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Enable creating dynamic filters for both sides; support right side bound collection [datafusion]
Posted by "crystalxyz (via GitHub)" <gi...@apache.org>.
crystalxyz commented on PR #18247:
URL: https://github.com/apache/datafusion/pull/18247#issuecomment-3600053215
I'm a little busy with schoolwork recently, so if anyone would love to grab on this, feel free to continue the work! Otherwise, I will be back after my final to complete the final task (update tests)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Allow dynamic filter pushdown to handle both left and right sides to be the probe side [datafusion]
Posted by "crystalxyz (via GitHub)" <gi...@apache.org>.
crystalxyz commented on PR #18247:
URL: https://github.com/apache/datafusion/pull/18247#issuecomment-3438855778
> I may be wrong here, but I believe hash join exec creates any dynamic filters any swapping, so the right side will always be the probe side.
@jonathanc-n Yeah thanks for pointing that out. I found that I didn't update the `probe_side()` function. I will try to refactor it, although the assumption (that the right side is always the probe side) is deeply embedded in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Allow dynamic filter pushdown to handle both left and right sides to be the probe side [datafusion]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on PR #18247:
URL: https://github.com/apache/datafusion/pull/18247#issuecomment-3438717493
cc @adriangb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Enable creating dynamic filters for both sides; support right side bound collection [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18247:
URL: https://github.com/apache/datafusion/pull/18247#issuecomment-3850692803
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Enable creating dynamic filters for both sides; support right side bound collection [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #18247: feat: Enable creating dynamic filters for both sides; support right side bound collection
URL: https://github.com/apache/datafusion/pull/18247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org