[GitHub] [nifi] nandorsoma commented on a diff in pull request #5224: NIFI-8710: Pass details instead of source ID for Provenance per the interface doc

["nandorsoma (via GitHub)" <gi...@apache.org>]

nandorsoma commented on code in PR #5224:
URL: https://github.com/apache/nifi/pull/5224#discussion_r1139424959


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -161,17 +161,21 @@ public void receive(final FlowFile flowFile, final String transitUri, final long
     }
 
     @Override
-    public void receive(final FlowFile flowFile, final String transitUri, final String sourceSystemFlowFileIdentifier, final long transmissionMillis) {
-        receive(flowFile, transitUri, sourceSystemFlowFileIdentifier, null, transmissionMillis);
+    public void receive(final FlowFile flowFile, final String transitUri, final String details, final long transmissionMillis) {
+        receive(flowFile, transitUri, null, details, transmissionMillis);
     }
 
     @Override
     public void receive(final FlowFile flowFile, final String transitUri, final String sourceSystemFlowFileIdentifier, final String details, final long transmissionMillis) {
         verifyFlowFileKnown(flowFile);
 
         try {
-            final ProvenanceEventRecord record = build(flowFile, ProvenanceEventType.RECEIVE)
-                .setTransitUri(transitUri).setSourceSystemFlowFileIdentifier(sourceSystemFlowFileIdentifier).setEventDuration(transmissionMillis).setDetails(details).build();
+            final ProvenanceEventBuilder builder = build(flowFile, ProvenanceEventType.RECEIVE);
+            builder.setTransitUri(transitUri);

Review Comment:
   Minor, but since it is a builder, it may be worth using the chain pattern for better readability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org