You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/06/22 15:26:34 UTC
Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441
Repository: mesos
Description
-------
The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated".
Diffs
-----
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/1/
Testing
-------
make check
Thanks,
Andrei Budnik
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote:
> > src/slave/http.cpp
> > Lines 1317-1318 (patched)
> > <https://reviews.apache.org/r/60369/diff/1/?file=1758431#file1758431line1317>
> >
> > Do we need this comment? Seems clear from the code
Fixed.
> On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote:
> > src/slave/http.cpp
> > Lines 1322 (patched)
> > <https://reviews.apache.org/r/60369/diff/1/?file=1758431#file1758431line1322>
> >
> > I'm not sure that it makes sense to be filtering in this manner here, since the user is not viewing the framework or executor, but rather the resources allocated to roles. It seems like this should be doing role-based authorization instead, as is done in the master side role endpoint:
> >
> > https://github.com/apache/mesos/blob/6b0ce8ff80e315fdfb22f0d7a2ed6d0947be7f11/src/master/http.cpp#L3363-L3420
Fixed.
> On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote:
> > src/tests/reservation_endpoints_tests.cpp
> > Lines 1747 (patched)
> > <https://reviews.apache.org/r/60369/diff/1/?file=1758432#file1758432line1747>
> >
> > This flag is deprecated now that we can persist role configuration within the registry, did you need to set this for the test to pass?
I'm getting following error without this flag: `Function call: error(0x7fff595959d8, @0x7facca60abd0 "Roles { role1 } are not present in the master's --roles")`
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review178867
-----------------------------------------------------------
On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated June 27, 2017, 5:10 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
>
>
> Diffs
> -----
>
> src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
> src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5
>
>
> Diff: https://reviews.apache.org/r/60369/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review178867
-----------------------------------------------------------
src/slave/http.cpp
Lines 1317-1318 (patched)
<https://reviews.apache.org/r/60369/#comment253163>
Do we need this comment? Seems clear from the code
src/slave/http.cpp
Lines 1322 (patched)
<https://reviews.apache.org/r/60369/#comment253164>
I'm not sure that it makes sense to be filtering in this manner here, since the user is not viewing the framework or executor, but rather the resources allocated to roles. It seems like this should be doing role-based authorization instead, as is done in the master side role endpoint:
https://github.com/apache/mesos/blob/6b0ce8ff80e315fdfb22f0d7a2ed6d0947be7f11/src/master/http.cpp#L3363-L3420
src/tests/reservation_endpoints_tests.cpp
Lines 1747 (patched)
<https://reviews.apache.org/r/60369/#comment253345>
This flag is deprecated now that we can persist role configuration within the registry, did you need to set this for the test to pass?
- Benjamin Mahler
On June 22, 2017, 3:26 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated June 22, 2017, 3:26 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
>
>
> Diffs
> -----
>
> src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
> src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5
>
>
> Diff: https://reviews.apache.org/r/60369/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/slave/http.cpp
> > Lines 1334-1344 (patched)
> > <https://reviews.apache.org/r/60369/diff/2/?file=1764200#file1764200line1334>
> >
> > Should we follow this pattern?
> >
> >
> > ```
> > writer->field(
> > "reserved_resources_full",
> > [&totalResources](JSON::ObjectWriter* writer) {
> > foreachpair (const string& role,
> > const Resources& resources,
> > totalResources.reservations()) {
> >
> > ```
Yeah, sure. Fixed.
> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/slave/http.cpp
> > Lines 1344 (patched)
> > <https://reviews.apache.org/r/60369/diff/2/?file=1764200#file1764200line1344>
> >
> > Nit: Add one blank line below.
Fixed.
> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/tests/reservation_endpoints_tests.cpp
> > Line 1739 (original), 1739 (patched)
> > <https://reviews.apache.org/r/60369/diff/2/?file=1764201#file1764201line1739>
> >
> > Nit: Add one blank line below.
Fixed.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179000
-----------------------------------------------------------
On June 28, 2017, 12:08 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 12:08 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
>
>
> Diffs
> -----
>
> src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
> src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5
>
>
> Diff: https://reviews.apache.org/r/60369/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179000
-----------------------------------------------------------
src/slave/http.cpp
Lines 1334-1344 (patched)
<https://reviews.apache.org/r/60369/#comment253387>
Should we follow this pattern?
```
writer->field(
"reserved_resources_full",
[&totalResources](JSON::ObjectWriter* writer) {
foreachpair (const string& role,
const Resources& resources,
totalResources.reservations()) {
```
src/slave/http.cpp
Lines 1344 (patched)
<https://reviews.apache.org/r/60369/#comment253381>
Nit: Add one blank line below.
src/tests/reservation_endpoints_tests.cpp
Line 1739 (original), 1739 (patched)
<https://reviews.apache.org/r/60369/#comment253382>
Nit: Add one blank line below.
- haosdent huang
On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated June 27, 2017, 5:10 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
>
>
> Diffs
> -----
>
> src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
> src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5
>
>
> Diff: https://reviews.apache.org/r/60369/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On June 29, 2017, 9:48 a.m., Benjamin Mahler wrote:
> > Thanks Andrei, the code looks good. Can you split the test out? That way I can give a ship it on the code change, while we continue working on the test.
https://reviews.apache.org/r/60539/
> On June 29, 2017, 9:48 a.m., Benjamin Mahler wrote:
> > src/slave/http.cpp
> > Lines 1326 (patched)
> > <https://reviews.apache.org/r/60369/diff/3/?file=1766140#file1766140line1326>
> >
> > How about a TODO here?
> >
> > TODO(abudnik): Consider storing the allocatedResources in the Slave struct rather than computing it here each time.
Added.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179240
-----------------------------------------------------------
On June 29, 2017, 3:23 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 3:23 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
>
>
> Diffs
> -----
>
> src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
>
>
> Diff: https://reviews.apache.org/r/60369/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179240
-----------------------------------------------------------
Thanks Andrei, the code looks good. Can you split the test out? That way I can give a ship it on the code change, while we continue working on the test.
src/slave/http.cpp
Lines 1326 (patched)
<https://reviews.apache.org/r/60369/#comment253885>
How about a TODO here?
TODO(abudnik): Consider storing the allocatedResources in the Slave struct rather than computing it here each time.
- Benjamin Mahler
On June 28, 2017, 12:08 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 12:08 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
>
>
> Diffs
> -----
>
> src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
> src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5
>
>
> Diff: https://reviews.apache.org/r/60369/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On July 3, 2017, 1:22 p.m., Benjamin Mahler wrote:
> > src/slave/http.cpp
> > Lines 1330-1334 (patched)
> > <https://reviews.apache.org/r/60369/diff/4/?file=1766945#file1766945line1330>
> >
> > Whoops, I should have noticed this earlier, but when going to commit this I was taking a careful look at the code. This isn't accounting for the pending tasks here:
> >
> > https://github.com/apache/mesos/blob/0d277bb64fa5a4d0b4f741daedf64095beab4773/src/slave/slave.hpp#L904-L905
> >
> > Unfortunately the logic is a little tricky. We have to include all of the pending task resources. Also, for each executor in the pending map, we have to add the ExecutorInfo resources only if it's absent from the 'executors' map. You'll want to do a read through of how the data structures are used to confirm whether I'm right. :)
> >
> > My suggestion here would be to have an `allocatedResources()` function within the `Framework` struct that contains this logic, and here in the http handler we just sum `allocatedResources()` across the frameworks.
Fixed.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179499
-----------------------------------------------------------
On July 3, 2017, 5:52 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 5:52 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
>
>
> Diffs
> -----
>
> src/slave/http.cpp 700871e1502a65b0bb1fc31219e09219dbdb5340
> src/slave/slave.hpp 5ede32d00c5dbf18dc0639ec7af5d2a86f86f619
> src/slave/slave.cpp 0e24b8cb8d1020af515e3d1862e121e1daf82ce9
>
>
> Diff: https://reviews.apache.org/r/60369/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179499
-----------------------------------------------------------
src/slave/http.cpp
Lines 1330-1334 (patched)
<https://reviews.apache.org/r/60369/#comment254243>
Whoops, I should have noticed this earlier, but when going to commit this I was taking a careful look at the code. This isn't accounting for the pending tasks here:
https://github.com/apache/mesos/blob/0d277bb64fa5a4d0b4f741daedf64095beab4773/src/slave/slave.hpp#L904-L905
Unfortunately the logic is a little tricky. We have to include all of the pending task resources. Also, for each executor in the pending map, we have to add the ExecutorInfo resources only if it's absent from the 'executors' map. You'll want to do a read through of how the data structures are used to confirm whether I'm right. :)
My suggestion here would be to have an `allocatedResources()` function within the `Framework` struct that contains this logic, and here in the http handler we just sum `allocatedResources()` across the frameworks.
- Benjamin Mahler
On June 29, 2017, 3:23 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 3:23 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
>
>
> Diffs
> -----
>
> src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
>
>
> Diff: https://reviews.apache.org/r/60369/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review180784
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 17, 2017, 5:45 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 5:45 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated". Note that this info might differ
> from the master's view about resource allocations.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3
>
>
> Diff: https://reviews.apache.org/r/60369/diff/8/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
-----------------------------------------------------------
(Updated July 17, 2017, 5:45 p.m.)
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441
Repository: mesos
Description
-------
The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated". Note that this info might differ
from the master's view about resource allocations.
Diffs (updated)
-----
src/slave/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3
Diff: https://reviews.apache.org/r/60369/diff/8/
Changes: https://reviews.apache.org/r/60369/diff/7-8/
Testing
-------
make check
Thanks,
Andrei Budnik
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review180615
-----------------------------------------------------------
src/slave/http.cpp
Line 1312 (original), 1321 (patched)
<https://reviews.apache.org/r/60369/#comment255817>
Hm.. this seems inconsistent. If we're filtering the allocated resources below based on whether the client is authorized to view the role, then the "reserved_resources" and "reserved_resources_full" should also be getting filtered in the same way?
I would suggest either (1) doing the filtering in front of this patch so that this patch filters consistently, or (2) omit filtering in this patch and introduce it on both in a patch after this one.
- Benjamin Mahler
On July 14, 2017, 3:37 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 3:37 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated". Note that this info might differ
> from the master's view about resource allocations.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2
>
>
> Diff: https://reviews.apache.org/r/60369/diff/7/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
-----------------------------------------------------------
(Updated July 14, 2017, 3:37 p.m.)
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441
Repository: mesos
Description (updated)
-------
The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated". Note that this info might differ
from the master's view about resource allocations.
Diffs (updated)
-----
src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2
Diff: https://reviews.apache.org/r/60369/diff/7/
Changes: https://reviews.apache.org/r/60369/diff/6-7/
Testing
-------
make check
Thanks,
Andrei Budnik
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
-----------------------------------------------------------
(Updated July 3, 2017, 5:52 p.m.)
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441
Repository: mesos
Description
-------
The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated".
Diffs (updated)
-----
src/slave/http.cpp 700871e1502a65b0bb1fc31219e09219dbdb5340
src/slave/slave.hpp 5ede32d00c5dbf18dc0639ec7af5d2a86f86f619
src/slave/slave.cpp 0e24b8cb8d1020af515e3d1862e121e1daf82ce9
Diff: https://reviews.apache.org/r/60369/diff/5/
Changes: https://reviews.apache.org/r/60369/diff/4-5/
Testing
-------
make check
Thanks,
Andrei Budnik
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
-----------------------------------------------------------
(Updated June 29, 2017, 3:23 p.m.)
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441
Repository: mesos
Description
-------
The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated".
Diffs (updated)
-----
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
Diff: https://reviews.apache.org/r/60369/diff/4/
Changes: https://reviews.apache.org/r/60369/diff/3-4/
Testing
-------
make check
Thanks,
Andrei Budnik
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
-----------------------------------------------------------
(Updated June 28, 2017, 12:08 p.m.)
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441
Repository: mesos
Description
-------
The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated".
Diffs (updated)
-----
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/3/
Changes: https://reviews.apache.org/r/60369/diff/2-3/
Testing
-------
make check
Thanks,
Andrei Budnik
Re: Review Request 60369: Exposed allocated resources per each role in
/state endpoint on agent.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
-----------------------------------------------------------
(Updated June 27, 2017, 5:10 p.m.)
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441
Repository: mesos
Description
-------
The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated".
Diffs (updated)
-----
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/2/
Changes: https://reviews.apache.org/r/60369/diff/1-2/
Testing
-------
make check
Thanks,
Andrei Budnik