[jira] [Comment Edited] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

["Haisheng Yuan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007796#comment-17007796 ] 

Haisheng Yuan edited comment on CALCITE-3285 at 1/3/20 10:20 PM:
-----------------------------------------------------------------

[~vladimirsitnikov] I checked your fix at https://github.com/apache/calcite/pull/1702/commits/686d985d4a45b1306d4d397ad51e6cc03fe3ba4d, in which you extract non-equi condition on top of MergeJoin, that may still generate wrong result for outer joins:
select * from foo left join bar on foo.a=bar.a and foo.b > bar.c;

Update:
Ah, never mind, I found you have changed EnumerableMergeJoin to match inner join only. 


was (Author: hyuan):
[~vladimirsitnikov] I checked your fix at https://github.com/apache/calcite/pull/1702/commits/686d985d4a45b1306d4d397ad51e6cc03fe3ba4d, in which you extract non-equi condition on top of MergeJoin, that may still generate wrong result for outer joins:
select * from foo left join bar on foo.a=bar.a and foo.b > bar.c;

> EnumerableMergeJoin should support non-equi join conditions
> -----------------------------------------------------------
>
>                 Key: CALCITE-3285
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3285
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Haisheng Yuan
>            Assignee: Jin Xing
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Calcite should be able to generate EnumerableMergeJoin with non-equi join conditions, as long as there are equi-join conditions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)