You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/03/13 22:10:58 UTC
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12747
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
IMPALA-7982: Add host network usage to profile
This change adds host network usage to profiles. For each host that
participates in the query execution it adds the incoming and outgoing
bandwidth across all interfaces excluding the local loopback interface.
This includes all data transmitted by the host as part of the execution
of a query, other queries, and other processes running on the same
system.
The change adds tests for the added functionality to the backend and end
to end tests.
Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
---
M be/src/runtime/query-state.cc
M be/src/util/system-state-info-test.cc
M be/src/util/system-state-info.cc
M be/src/util/system-state-info.h
M tests/query_test/test_observability.py
5 files changed, 253 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/12747/1
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "John Sherman (Code Review)" <ge...@cloudera.org>.
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info.cc
File be/src/util/system-state-info.cc:
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info.cc@73
PS2, Line 73: LOG(WARNING) << "Could not open " << path << ": " << GetStrErrMsg() << endl;
Should you just print the error from the status? or is the errno still correctly preserved for GetStrErrMsg to determine the error msg? (Same applies to ReadCurrentProcNetDev)
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 27 Mar 2019 19:20:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello John Sherman, Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12747
to look at the new patch set (#3).
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
IMPALA-7982: Add host network usage to profile
This change adds host network usage to profiles. For each host that
participates in the query execution it adds the incoming and outgoing
bandwidth across all interfaces excluding the local loopback interface.
This includes all data transmitted by the host as part of the execution
of a query, other queries, and other processes running on the same
system.
The change adds tests for the added functionality to the backend and end
to end tests.
Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
---
M be/src/runtime/query-state.cc
M be/src/util/system-state-info-test.cc
M be/src/util/system-state-info.cc
M be/src/util/system-state-info.h
M tests/query_test/test_observability.py
5 files changed, 263 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/12747/3
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3968/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 29 Mar 2019 23:41:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
IMPALA-7982: Add host network usage to profile
This change adds host network usage to profiles. For each host that
participates in the query execution it adds the incoming and outgoing
bandwidth across all interfaces excluding the local loopback interface.
This includes all data transmitted by the host as part of the execution
of a query, other queries, and other processes running on the same
system.
The change adds tests for the added functionality to the backend and end
to end tests.
Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Reviewed-on: http://gerrit.cloudera.org:8080/12747
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/query-state.cc
M be/src/util/system-state-info-test.cc
M be/src/util/system-state-info.cc
M be/src/util/system-state-info.h
M tests/query_test/test_observability.py
5 files changed, 263 insertions(+), 42 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2470/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 00:10:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12747
to look at the new patch set (#2).
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
IMPALA-7982: Add host network usage to profile
This change adds host network usage to profiles. For each host that
participates in the query execution it adds the incoming and outgoing
bandwidth across all interfaces excluding the local loopback interface.
This includes all data transmitted by the host as part of the execution
of a query, other queries, and other processes running on the same
system.
The change adds tests for the added functionality to the backend and end
to end tests.
Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
---
M be/src/runtime/query-state.cc
M be/src/util/system-state-info-test.cc
M be/src/util/system-state-info.cc
M be/src/util/system-state-info.h
M tests/query_test/test_observability.py
5 files changed, 262 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/12747/2
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info.cc
File be/src/util/system-state-info.cc:
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info.cc@73
PS2, Line 73: LOG(WARNING) << "Could not open " << path << ": " << GetStrErrMsg() << endl;
> Should you just print the error from the status? or is the errno still corr
Done
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 28 Mar 2019 20:23:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 3:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc
File be/src/util/system-state-info-test.cc:
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@79
PS3, Line 79: string dev_net = R"(Inter-| Receive | Transmit
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@80
PS3, Line 80: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@81
PS3, Line 81: lo: 12178099975318 24167151765 0 0 0 0 0 0 12178099975318 24167151765 0 0 0 0 0 0
line too long (146 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@82
PS3, Line 82: br-c4d9b4cafca2: 1025814 409 0 0 0 0 0 0 70616330 1638104 0 0 0 0 0 0
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@83
PS3, Line 83: eth0: 366039609986 388580561 0 2 0 0 0 62231368 95492744135 174535524 0 0 0 0 0 0)";
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@134
PS3, Line 134: string dev_net_1 = R"(Inter-| Receive | Transmit
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@135
PS3, Line 135: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@136
PS3, Line 136: lo: 1000 2000 0 0 0 0 0 0 3000 4000 0 0 0 0 0 0
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@137
PS3, Line 137: br-c4d9b4cafca2: 5000 409 0 0 0 0 0 0 6000 7000 0 0 0 0 0 0
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@138
PS3, Line 138: eth0: 8000 9000 0 2 0 0 0 10000 11000 12000 0 0 0 0 0 0)";
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@139
PS3, Line 139: string dev_net_2 = R"(Inter-| Receive | Transmit
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@140
PS3, Line 140: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@141
PS3, Line 141: lo: 2000 4000 0 0 0 0 0 0 6000 8000 0 0 0 0 0 0
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@142
PS3, Line 142: br-c4d9b4cafca2: 7000 609 0 0 0 0 0 0 12000 14000 0 0 0 0 0 0
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/3/be/src/util/system-state-info-test.cc@143
PS3, Line 143: eth0: 10000 11000 0 2 0 0 0 10000 11000 12000 0 0 0 0 0 0)";
line too long (120 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 28 Mar 2019 20:23:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info.cc
File be/src/util/system-state-info.cc:
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info.cc@116
PS1, Line 116: stringstream ss;
: string path = "/proc/net/dev";
: ifstream net_dev(path, ios::in);
: if (!net_dev) {
: LOG(WARNING) << "Could not open " << path << ": " << GetStrErrMsg() << endl;
: return;
: }
: DCHECK(net_dev.is_open());
: ss << net_dev.rdbuf();
: ReadProcNetDevString(ss.str());
> are these C++ IO functions exception-safe? Consider using ReadFileToString
Done
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info.cc@156
PS1, Line 156: if (if_name.find("lo:") == 0) {
> HasPrefixString
Done
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 19 Mar 2019 23:29:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 1:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc
File be/src/util/system-state-info-test.cc:
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@79
PS1, Line 79: string dev_net = R"(Inter-| Receive | Transmit
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@80
PS1, Line 80: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@81
PS1, Line 81: lo: 12178099975318 24167151765 0 0 0 0 0 0 12178099975318 24167151765 0 0 0 0 0 0
line too long (146 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@82
PS1, Line 82: br-c4d9b4cafca2: 1025814 409 0 0 0 0 0 0 70616330 1638104 0 0 0 0 0 0
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@83
PS1, Line 83: eth0: 366039609986 388580561 0 2 0 0 0 62231368 95492744135 174535524 0 0 0 0 0 0)";
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@134
PS1, Line 134: string dev_net_1 = R"(Inter-| Receive | Transmit
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@135
PS1, Line 135: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@136
PS1, Line 136: lo: 1000 2000 0 0 0 0 0 0 3000 4000 0 0 0 0 0 0
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@137
PS1, Line 137: br-c4d9b4cafca2: 5000 409 0 0 0 0 0 0 6000 7000 0 0 0 0 0 0
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@138
PS1, Line 138: eth0: 8000 9000 0 2 0 0 0 10000 11000 12000 0 0 0 0 0 0)";
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@139
PS1, Line 139: string dev_net_2 = R"(Inter-| Receive | Transmit
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@140
PS1, Line 140: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@141
PS1, Line 141: lo: 2000 4000 0 0 0 0 0 0 6000 8000 0 0 0 0 0 0
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@142
PS1, Line 142: br-c4d9b4cafca2: 7000 609 0 0 0 0 0 0 12000 14000 0 0 0 0 0 0
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info-test.cc@143
PS1, Line 143: eth0: 10000 11000 0 2 0 0 0 10000 11000 12000 0 0 0 0 0 0)";
line too long (120 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 22:12:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info.cc
File be/src/util/system-state-info.cc:
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info.cc@116
PS1, Line 116: stringstream ss;
: string path = "/proc/net/dev";
: ifstream net_dev(path, ios::in);
: if (!net_dev) {
: LOG(WARNING) << "Could not open " << path << ": " << GetStrErrMsg() << endl;
: return;
: }
: DCHECK(net_dev.is_open());
: ss << net_dev.rdbuf();
: ReadProcNetDevString(ss.str());
are these C++ IO functions exception-safe? Consider using ReadFileToString from kudu/util/env.h which is slightly easier to follow perhaps?
http://gerrit.cloudera.org:8080/#/c/12747/1/be/src/util/system-state-info.cc@156
PS1, Line 156: if (if_name.find("lo:") == 0) {
HasPrefixString
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 16 Mar 2019 00:07:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 30 Mar 2019 04:39:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2427/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 22:42:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2581/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 28 Mar 2019 21:02:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 28 Mar 2019 22:26:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 2:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc
File be/src/util/system-state-info-test.cc:
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@79
PS2, Line 79: string dev_net = R"(Inter-| Receive | Transmit
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@80
PS2, Line 80: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@81
PS2, Line 81: lo: 12178099975318 24167151765 0 0 0 0 0 0 12178099975318 24167151765 0 0 0 0 0 0
line too long (146 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@82
PS2, Line 82: br-c4d9b4cafca2: 1025814 409 0 0 0 0 0 0 70616330 1638104 0 0 0 0 0 0
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@83
PS2, Line 83: eth0: 366039609986 388580561 0 2 0 0 0 62231368 95492744135 174535524 0 0 0 0 0 0)";
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@134
PS2, Line 134: string dev_net_1 = R"(Inter-| Receive | Transmit
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@135
PS2, Line 135: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@136
PS2, Line 136: lo: 1000 2000 0 0 0 0 0 0 3000 4000 0 0 0 0 0 0
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@137
PS2, Line 137: br-c4d9b4cafca2: 5000 409 0 0 0 0 0 0 6000 7000 0 0 0 0 0 0
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@138
PS2, Line 138: eth0: 8000 9000 0 2 0 0 0 10000 11000 12000 0 0 0 0 0 0)";
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@139
PS2, Line 139: string dev_net_2 = R"(Inter-| Receive | Transmit
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@140
PS2, Line 140: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
line too long (124 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@141
PS2, Line 141: lo: 2000 4000 0 0 0 0 0 0 6000 8000 0 0 0 0 0 0
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@142
PS2, Line 142: br-c4d9b4cafca2: 7000 609 0 0 0 0 0 0 12000 14000 0 0 0 0 0 0
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info-test.cc@143
PS2, Line 143: eth0: 10000 11000 0 2 0 0 0 10000 11000 12000 0 0 0 0 0 0)";
line too long (120 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 19 Mar 2019 23:29:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile
......................................................................
Patch Set 5: Code-Review+2
Rebased, carrying Todd's +2
--
To view, visit http://gerrit.cloudera.org:8080/12747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 29 Mar 2019 23:40:46 +0000
Gerrit-HasComments: No