You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/03 16:24:55 UTC

[GitHub] [arrow-datafusion] alamb opened a new issue, #6211: Port tests in `functions.rs` to sqllogictest

alamb opened a new issue, #6211:
URL: https://github.com/apache/arrow-datafusion/issues/6211

   ### Is your feature request related to a problem or challenge?
   
   Part of https://github.com/apache/arrow-datafusion/issues/6195. We are trying to keep the DataFusion code base clean and easy to contribute to and modify. Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily 
   
   ### Describe the solution you'd like
   
   Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/expr.rs to `scalar.slt` in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests/test_files
   
   The target file already exists:
   https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/scalar.slt
   
   Notes: 
   1. Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests
   2. There may be some duplication when porting -- it is fine to port as is or if you want port just what is missing
   3. If you don't know how to port any particular test, please leave it in the .rs or ask on the pull request
   
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] jackwener closed issue #6211: Port tests in `functions.rs` to sqllogictest

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener closed issue #6211: Port tests in `functions.rs` to sqllogictest
URL: https://github.com/apache/arrow-datafusion/issues/6211


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org