You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/19 05:58:21 UTC

[GitHub] [spark] leanken opened a new pull request #30092: [SPARK-33139][SQL][FollowUp] Avoid using reflect call on session.py.

leanken opened a new pull request #30092:
URL: https://github.com/apache/spark/pull/30092


   ### What changes were proposed in this pull request?
   
   In [SPARK-33139](https://github.com/apache/spark/pull/30042), I was using reflect "Class.forName" in python code to invoke method in SparkSession which is not recommended. using getattr to access "SparkSession$.Module$" instead. 
   
   ### Why are the changes needed?
   
   Code refine.
   
   
   ### Does this PR introduce any user-facing change?
   No.
   
   
   ### How was this patch tested?
   
   Existing tests.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #30092: [SPARK-33139][SQL][FOLLOW-UP] Avoid using reflect call on session.py

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711773377


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30092: [SPARK-33139][SQL][FOLLOW-UP] Avoid using reflect call on session.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711712393






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30092: [SPARK-33139][SQL][FOLLOW-UP] Avoid using reflect call on session.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711677137






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30092: [SPARK-33139][SQL][FOLLOW-UP] Avoid using reflect call on session.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711677137






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30092: [SPARK-33139][SQL][FollowUp] Avoid using reflect call on session.py.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711621138


   **[Test build #129986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129986/testReport)** for PR 30092 at commit [`fb80830`](https://github.com/apache/spark/commit/fb80830d31a2ec4e6e38a1999aeab0f4b51f9f9f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #30092: [SPARK-33139][SQL][FOLLOW-UP] Avoid using reflect call on session.py

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30092:
URL: https://github.com/apache/spark/pull/30092


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30092: [SPARK-33139][SQL][FOLLOW-UP] Avoid using reflect call on session.py

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711621138


   **[Test build #129986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129986/testReport)** for PR 30092 at commit [`fb80830`](https://github.com/apache/spark/commit/fb80830d31a2ec4e6e38a1999aeab0f4b51f9f9f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30092: [SPARK-33139][SQL][FollowUp] Avoid using reflect call on session.py.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711672334


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34593/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30092: [SPARK-33139][SQL][FOLLOW-UP] Avoid using reflect call on session.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711712342


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34593/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] leanken commented on pull request #30092: [SPARK-33139][SQL][FollowUp] Avoid using reflect call on session.py.

Posted by GitBox <gi...@apache.org>.
leanken commented on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711620381


   @HyukjinKwon FYI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30092: [SPARK-33139][SQL][FOLLOW-UP] Avoid using reflect call on session.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711712393






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30092: [SPARK-33139][SQL][FollowUp] Avoid using reflect call on session.py.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30092:
URL: https://github.com/apache/spark/pull/30092#issuecomment-711674709


   **[Test build #129986 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129986/testReport)** for PR 30092 at commit [`fb80830`](https://github.com/apache/spark/commit/fb80830d31a2ec4e6e38a1999aeab0f4b51f9f9f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org