[kudu-CR] master: always use smart pointers when accessing TableInfo and TabletInfo

["Dan Burkert (Code Review)" <ge...@cloudera.org>]

Dan Burkert has posted comments on this change.

Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo
......................................................................


Patch Set 3:

(1 comment)

A bunch of the s/push_back/emplace_back calls aren't really doing anything different because they are operating on crefs.  It's not wrong, but I don't think it's necessarily better to use emplace_back.  I don't feel strongly about it.

http://gerrit.cloudera.org:8080/#/c/7909/3/src/kudu/master/sys_catalog.h
File src/kudu/master/sys_catalog.h:

Line 243:   void ReqAddTable(tserver::WriteRequestPB* req,
Looks like these could take TableInfo by cref.


-- 
To view, visit http://gerrit.cloudera.org:8080/7909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c74f2aa048ee85cc3a5f863ce8f38147e78c5ae
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes