You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2018/08/28 11:21:04 UTC

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20965#discussion_r213273861
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -950,6 +950,15 @@ object SQLConf {
           .booleanConf
           .createWithDefault(true)
     
    +  val CODEGEN_SPLIT_AGGREGATE_FUNC =
    +    buildConf("spark.sql.codegen.aggregate.splitAggregateFunc.enabled")
    +      .internal()
    +      .doc("When true, the code generator would aggregation code into individual methods " +
    --- End diff --
    
    very nit: `aggregation` -> `aggregate`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org