You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/22 09:16:05 UTC

[GitHub] [spark] beliefer opened a new pull request #26204: [SPARK-29548][Core] Redirect system print stream to log4j and improve robustness

beliefer opened a new pull request #26204: [SPARK-29548][Core] Redirect system print stream to log4j and improve robustness
URL: https://github.com/apache/spark/pull/26204
 
 
   ### What changes were proposed in this pull request?
   In a production environment, user behavior is highly random and uncertain.
   For example: Users use `System.out` or `System.err` to print information.
   But the system print stream may cause some trouble, such as: the disk file is too large.
   
   In my production environment, it causes the disk to be full and let [NodeManager] works not fine.
   
   A method of threat is to forbid the use of `System.out` or `System.err`. But unfriendly to the users.
   A better method is to redirecting the system print stream to `Log4j` and Spark can take advantage of `Log4j`'s split log.
   
   
   ### Why are the changes needed?
   Improve robustness about system `PrintStream`.
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   Exists UT.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org