You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "tsreaper (via GitHub)" <gi...@apache.org> on 2023/02/01 10:37:13 UTC

[GitHub] [flink] tsreaper commented on pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

tsreaper commented on PR #21393:
URL: https://github.com/apache/flink/pull/21393#issuecomment-1411839600

   Thanks @kristoffSC for your effort in this long running pull request. I don't have much to say now. You did a great job.
   
   One last comment: Add a test to `CodeSplitITCase` to address why this issue is brought up. Maciej Bryński's comment in the original JIRA ticket might be useful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org