You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/07/17 12:08:54 UTC

Review Request 60906: Add SOLR to BigInsights 4.2.5 stack

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60906/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.


Bugs: AMBARI-21487
    https://issues.apache.org/jira/browse/AMBARI-21487


Repository: ambari


Description
-------

SOLR is missing from 4.2.5 stack. I moved the solr stack code from common-services to stacks/BigInsights/4.2.5/

note: in the stack metainfo.xml there is an <extends> tag for 4.2 stack, that means a solr-site config type is added during ambari upgrade (because of on-ambari-upgrade add="true" tags), because of that solr needs to be restarted. if i change the on-ambari-upgrade add flag to false, its not needed to restart SOLR, but because of the <extends> of metainfo.xml, db check will fail. So i kept that behaviour.

next: HDP upgrade


Diffs
-----

  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/alerts.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-audit.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-plugin-properties.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-policymgr-ssl.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-security.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-client-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-xml.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/kerberos.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/setup_ranger_solr.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/setup_solr.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/solr.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/solr_client.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/status_params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/templates/solr_jaas.conf.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-client-log4j.properties.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-env.sh.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-log4j.properties.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr.xml.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/quicklinks/quicklinks.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/themes/theme.json PRE-CREATION 


Diff: https://reviews.apache.org/r/60906/diff/1/


Testing
-------

test manually:
Upgrade ambari -> start/stop solr.


Thanks,

Oliver Szabo

Re: Review Request 60906: Add SOLR to BigInsights 4.2.5 stack

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60906/#review180705
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On July 17, 2017, 12:08 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60906/
> -----------------------------------------------------------
> 
> (Updated July 17, 2017, 12:08 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21487
>     https://issues.apache.org/jira/browse/AMBARI-21487
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> SOLR is missing from 4.2.5 stack. I moved the solr stack code from common-services to stacks/BigInsights/4.2.5/
> 
> note: in the stack metainfo.xml there is an <extends> tag for 4.2 stack, that means a solr-site config type is added during ambari upgrade (because of on-ambari-upgrade add="true" tags), because of that solr needs to be restarted. if i change the on-ambari-upgrade add flag to false, its not needed to restart SOLR, but because of the <extends> of metainfo.xml, db check will fail. So i kept that behaviour.
> 
> next: HDP upgrade
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/alerts.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-audit.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-plugin-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-policymgr-ssl.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-security.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-client-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-xml.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/setup_ranger_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/setup_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/solr_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/templates/solr_jaas.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-client-log4j.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-env.sh.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-log4j.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr.xml.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/quicklinks/quicklinks.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/themes/theme.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60906/diff/1/
> 
> 
> Testing
> -------
> 
> test manually:
> Upgrade ambari -> start/stop solr.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60906: Add SOLR to BigInsights 4.2.5 stack

Posted by Attila Doroszlai <ad...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60906/#review180696
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Doroszlai


On July 17, 2017, 2:08 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60906/
> -----------------------------------------------------------
> 
> (Updated July 17, 2017, 2:08 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21487
>     https://issues.apache.org/jira/browse/AMBARI-21487
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> SOLR is missing from 4.2.5 stack. I moved the solr stack code from common-services to stacks/BigInsights/4.2.5/
> 
> note: in the stack metainfo.xml there is an <extends> tag for 4.2 stack, that means a solr-site config type is added during ambari upgrade (because of on-ambari-upgrade add="true" tags), because of that solr needs to be restarted. if i change the on-ambari-upgrade add flag to false, its not needed to restart SOLR, but because of the <extends> of metainfo.xml, db check will fail. So i kept that behaviour.
> 
> next: HDP upgrade
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/alerts.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-audit.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-plugin-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-policymgr-ssl.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-security.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-client-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-xml.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/setup_ranger_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/setup_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/solr_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/templates/solr_jaas.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-client-log4j.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-env.sh.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-log4j.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr.xml.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/quicklinks/quicklinks.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/themes/theme.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60906/diff/1/
> 
> 
> Testing
> -------
> 
> test manually:
> Upgrade ambari -> start/stop solr.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60906: Add SOLR to BigInsights 4.2.5 stack

Posted by Jonathan Hurley <jh...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60906/#review180682
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On July 17, 2017, 8:08 a.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60906/
> -----------------------------------------------------------
> 
> (Updated July 17, 2017, 8:08 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21487
>     https://issues.apache.org/jira/browse/AMBARI-21487
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> SOLR is missing from 4.2.5 stack. I moved the solr stack code from common-services to stacks/BigInsights/4.2.5/
> 
> note: in the stack metainfo.xml there is an <extends> tag for 4.2 stack, that means a solr-site config type is added during ambari upgrade (because of on-ambari-upgrade add="true" tags), because of that solr needs to be restarted. if i change the on-ambari-upgrade add flag to false, its not needed to restart SOLR, but because of the <extends> of metainfo.xml, db check will fail. So i kept that behaviour.
> 
> next: HDP upgrade
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/alerts.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-audit.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-plugin-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-policymgr-ssl.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/ranger-solr-security.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-client-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/configuration/solr-xml.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/setup_ranger_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/setup_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/solr.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/solr_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/templates/solr_jaas.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-client-log4j.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-env.sh.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr-log4j.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/properties/solr.xml.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/quicklinks/quicklinks.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/themes/theme.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60906/diff/1/
> 
> 
> Testing
> -------
> 
> test manually:
> Upgrade ambari -> start/stop solr.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>