You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/24 08:53:11 UTC

[GitHub] [maven-shade-plugin] kriegaex edited a comment on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

kriegaex edited a comment on pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-846887726


   @rmannibucau: I showed you mine. If you show me yours, I can say more about it. Is it a PR on top of my PR or a reimplementation of it? I would not be sad to throw away mine, because the sole purpose of it is to fix the problem. If it just remains to be the trigger for you to fix it in a more elegant way, it still served its purpose. So how are we going to do this?
   
   **Update:** OK, I just noticed the link in your message and can see that your commit [piggy-backs on mine](https://github.com/apache/maven-shade-plugin/compare/master...rmannibucau:MSHADE-391). Going to take a look now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org