You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/21 21:06:11 UTC

[GitHub] [nifi] alopresto opened a new pull request #4418: NIFI-7657 Suppressed log messages from failed authentication requests when HTTPS is not enabled

alopresto opened a new pull request #4418:
URL: https://github.com/apache/nifi/pull/4418


   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   #### Description of PR
   
   _NiFi UI would make requests for authentication even when HTTPS is disabled and therefore no authentication is enabled. When these (expected) messages appeared in the `nifi-user.log`, they would often confuse users. This PR removes those messages by default._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [x] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] alopresto commented on pull request #4418: NIFI-7657 Suppressed log messages from failed authentication requests when HTTPS is not enabled

Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4418:
URL: https://github.com/apache/nifi/pull/4418#issuecomment-662178019


   Re-running CI jobs as the Maven failures should be resolved thanks to PR 4419. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] pvillard31 commented on pull request #4418: NIFI-7657 Suppressed log messages from failed authentication requests when HTTPS is not enabled

Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4418:
URL: https://github.com/apache/nifi/pull/4418#issuecomment-662425792


   Gave it a try and it LGTM. Merging to main, thanks @alopresto 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] alopresto commented on pull request #4418: NIFI-7657 Suppressed log messages from failed authentication requests when HTTPS is not enabled

Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4418:
URL: https://github.com/apache/nifi/pull/4418#issuecomment-662178370


   Had to rebase on `main` to include the fix; now CI jobs are running again. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #4418: NIFI-7657 Suppressed log messages from failed authentication requests when HTTPS is not enabled

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4418:
URL: https://github.com/apache/nifi/pull/4418


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org