You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "ayushtkn (via GitHub)" <gi...@apache.org> on 2023/06/21 05:27:15 UTC
[GitHub] [tez] ayushtkn opened a new pull request, #293: TEZ-4472: Use unique DAG names in tests.
ayushtkn opened a new pull request, #293:
URL: https://github.com/apache/tez/pull/293
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1603895865
thanks @ayushtkn ! 1 more to address, can you please check TestLocalMode too? I remember that what my original headache that I workaround with something like (with respecting the junit parameters)
```
private String generateDagName(String baseName) {
return baseName + (useDfs ? "_useDfs" : "") + (useLocalModeWithoutNetwork ? "_useLocalModeWithoutNetwork" : "");
}
```
and:
```
DAG dag1 = createSimpleDAG("dag1", FailingProcessor.class.getName());
DAG dag1 = createSimpleDAG("DAG-testNoSysExitOnFailinglDAG", FailingProcessor.class.getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] ayushtkn commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1604142689
That checkstyle isn’t on me, I just touched that line, test failure doesn’t look related either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1600281657
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 15 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 6m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 34s | master passed |
| +1 :green_heart: | compile | 2m 5s | master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | compile | 1m 56s | master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | checkstyle | 2m 8s | master passed |
| +1 :green_heart: | javadoc | 1m 48s | master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javadoc | 1m 35s | master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +0 :ok: | spotbugs | 0m 52s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 10s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 10s | the patch passed |
| +1 :green_heart: | compile | 1m 15s | the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javac | 1m 15s | the patch passed |
| +1 :green_heart: | compile | 1m 5s | the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | javac | 1m 5s | the patch passed |
| -0 :warning: | checkstyle | 0m 27s | tez-dag: The patch generated 6 new + 277 unchanged - 6 fixed = 283 total (was 283) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | findbugs | 2m 54s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 15s | tez-api in the patch passed. |
| -1 :x: | unit | 5m 38s | tez-dag in the patch failed. |
| -1 :x: | unit | 37m 3s | tez-tests in the patch failed. |
| +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. |
| | | 85m 24s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.dag.history.utils.TestDAGUtils |
| | tez.test.TestRecovery |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/293 |
| JIRA Issue | TEZ-4472 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 4a2635046113 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / d20f3347d |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/1/artifact/out/diff-checkstyle-tez-dag.txt |
| unit | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/1/artifact/out/patch-unit-tez-dag.txt |
| unit | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/1/artifact/out/patch-unit-tez-tests.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/1/testReport/ |
| Max. process+thread count | 1374 (vs. ulimit of 5500) |
| modules | C: tez-api tez-dag tez-tests U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/1/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1600454732
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 15 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 29s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 7s | master passed |
| +1 :green_heart: | compile | 2m 8s | master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | compile | 1m 58s | master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | checkstyle | 1m 45s | master passed |
| +1 :green_heart: | javadoc | 1m 36s | master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javadoc | 1m 32s | master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +0 :ok: | spotbugs | 0m 55s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 20s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 16s | the patch passed |
| +1 :green_heart: | compile | 1m 24s | the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javac | 1m 24s | the patch passed |
| +1 :green_heart: | compile | 1m 12s | the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | javac | 1m 12s | the patch passed |
| -0 :warning: | checkstyle | 0m 27s | tez-dag: The patch generated 1 new + 276 unchanged - 7 fixed = 277 total (was 283) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | findbugs | 3m 9s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 17s | tez-api in the patch passed. |
| +1 :green_heart: | unit | 5m 14s | tez-dag in the patch passed. |
| +1 :green_heart: | unit | 41m 9s | tez-tests in the patch passed. |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 89m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/293 |
| JIRA Issue | TEZ-4472 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 59cde4a818be 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / d20f3347d |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/2/artifact/out/diff-checkstyle-tez-dag.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/2/testReport/ |
| Max. process+thread count | 1346 (vs. ulimit of 5500) |
| modules | C: tez-api tez-dag tez-tests U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/2/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1604006912
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 15 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 6m 9s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 50s | master passed |
| +1 :green_heart: | compile | 2m 4s | master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | compile | 1m 56s | master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | checkstyle | 2m 6s | master passed |
| +1 :green_heart: | javadoc | 1m 43s | master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javadoc | 1m 36s | master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +0 :ok: | spotbugs | 0m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 41s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 9s | the patch passed |
| +1 :green_heart: | compile | 1m 16s | the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javac | 1m 16s | the patch passed |
| +1 :green_heart: | compile | 1m 4s | the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| -0 :warning: | checkstyle | 0m 27s | tez-dag: The patch generated 1 new + 276 unchanged - 7 fixed = 277 total (was 283) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | findbugs | 2m 52s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 16s | tez-api in the patch passed. |
| -1 :x: | unit | 5m 9s | tez-dag in the patch failed. |
| +1 :green_heart: | unit | 41m 3s | tez-tests in the patch passed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 89m 23s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.dag.app.rm.TestTaskScheduler |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/293 |
| JIRA Issue | TEZ-4472 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux edd9f98f2932 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / d20f3347d |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/3/artifact/out/diff-checkstyle-tez-dag.txt |
| unit | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/3/artifact/out/patch-unit-tez-dag.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/3/testReport/ |
| Max. process+thread count | 1426 (vs. ulimit of 5500) |
| modules | C: tez-api tez-dag tez-tests U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/3/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog merged pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog merged PR #293:
URL: https://github.com/apache/tez/pull/293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on a diff in pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #293:
URL: https://github.com/apache/tez/pull/293#discussion_r1238893337
##########
tez-api/src/test/java/org/apache/tez/client/TestTezClient.java:
##########
@@ -203,12 +203,12 @@ TezClientForTest configureAndCreateTezClient(Map<String, LocalResource> lrs, boo
@Test (timeout = 5000)
public void testTezclientApp() throws Exception {
- testTezClient(false, true);
+ testTezClient(false, true, "testTezclientApp");
Review Comment:
I know this patch is not about that, but...: can you please fix all occurrences of "Tezclient" -> "TezClient"?
feel free to create a new ticket if you want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] ayushtkn commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1600321137
Fixed test, the checkstyle warnings in ``TestCommit`` weren't actually induced here, but got pop up because I touched those lines, had to change the variable name to get them going
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1604186652
agreed, TestTaskScheduler failure is crazy, nothing to do with this patch, we don't need a new precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1604045370
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 16 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 6m 27s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 14s | master passed |
| +1 :green_heart: | compile | 2m 1s | master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | compile | 1m 53s | master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | checkstyle | 2m 6s | master passed |
| +1 :green_heart: | javadoc | 1m 40s | master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javadoc | 1m 37s | master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +0 :ok: | spotbugs | 0m 52s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 21s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 8s | the patch passed |
| +1 :green_heart: | compile | 1m 13s | the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javac | 1m 13s | the patch passed |
| +1 :green_heart: | compile | 1m 5s | the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | javac | 1m 5s | the patch passed |
| -0 :warning: | checkstyle | 0m 27s | tez-dag: The patch generated 1 new + 276 unchanged - 7 fixed = 277 total (was 283) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| +1 :green_heart: | findbugs | 2m 54s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 16s | tez-api in the patch passed. |
| +1 :green_heart: | unit | 5m 10s | tez-dag in the patch passed. |
| -1 :x: | unit | 39m 27s | tez-tests in the patch failed. |
| +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. |
| | | 88m 5s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.test.TestRecovery |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/293 |
| JIRA Issue | TEZ-4472 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 7e7bc7e69129 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / d20f3347d |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09 |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/4/artifact/out/diff-checkstyle-tez-dag.txt |
| unit | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/4/artifact/out/patch-unit-tez-tests.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/4/testReport/ |
| Max. process+thread count | 1391 (vs. ulimit of 5500) |
| modules | C: tez-api tez-dag tez-tests U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-293/4/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #293:
URL: https://github.com/apache/tez/pull/293#issuecomment-1603127549
@ayushtkn: this patch covers much more test classes than I expected, which is a huge work thanks!
I feel that as you're about addressing as much as possible, maybe it's time to figure out a test dag name convention: some uses "Dag-" prefix, other uses "testdag", yet another uses only the test case's name...I don't have strong opinion about that, and I'm afraid it can still diverge later, but now it would make sense to unify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on a diff in pull request #293: TEZ-4472: Use unique DAG names in tests.
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #293:
URL: https://github.com/apache/tez/pull/293#discussion_r1238886458
##########
tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestVertexImpl.java:
##########
@@ -809,9 +809,10 @@ private DAGPlan createDAGPlanWithNonExistVertexManager() {
return dag;
}
- private DAGPlan createDAGPlanWithMixedEdges() {
+ private DAGPlan createDAGPlanWithMixedEdges(String dagNeme) {
LOG.info("Setting up mixed edge dag plan");
- org.apache.tez.dag.api.DAG dag = org.apache.tez.dag.api.DAG.create("MixedEdges");
+ org.apache.tez.dag.api.DAG dag =
+ org.apache.tez.dag.api.DAG.create("Dag-MixedEdges-" + dagNeme);
Review Comment:
typo: neme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org