You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by lstav <gi...@git.apache.org> on 2017/01/06 13:46:42 UTC
[GitHub] accumulo pull request #198: Accumulo 4061
GitHub user lstav opened a pull request:
https://github.com/apache/accumulo/pull/198
Accumulo 4061
Fixes ACCUMULO-4061. I started working on the shell code on a separate [branch](accumulo/tree/ACCUMULO-4558), which is why I removed the commits done for #ACCUMULO-4558 from this branch and moved them to the new one. If you wish to see what the commits comments were, you can look at them from the other branch (the commits will have ACCUMULO-4061 in the message).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lstav/accumulo ACCUMULO-4061
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #198
----
commit ecd4234aae90a5b1971f06c36a454274d17f15d8
Author: Luis Tavarez <ze...@outlook.com>
Date: 2016-12-30T14:11:56Z
ACCUMULO-4061 Tablet Servers now save the version number when they get created
commit ff8e3b86962d12629a5ae5cfd775a2c044f65fb6
Author: Luis Tavarez <ze...@outlook.com>
Date: 2017-01-04T15:26:05Z
ACCUMULO-4061 Modified thrift file
commit c763e5751da53331abd30c795ff454ce733ef28b
Author: Luis Tavarez <ze...@outlook.com>
Date: 2017-01-04T15:26:38Z
ACCUMULO-4061 Re-generated java file
commit 67c9433e13605d6521266d1a6de0f3ebf6ec15f4
Author: Luis Tavarez <ze...@outlook.com>
Date: 2017-01-04T15:32:33Z
ACCUMULO-4061 Removed set method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #198: Accumulo 4061
Posted by lstav <gi...@git.apache.org>.
Github user lstav closed the pull request at:
https://github.com/apache/accumulo/pull/198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #198: Accumulo 4061
Posted by lstav <gi...@git.apache.org>.
Github user lstav commented on the issue:
https://github.com/apache/accumulo/pull/198
It would be interesting to see and try to write a test for it. I would appreciate if you point me in the right direction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #198: Accumulo 4061
Posted by lstav <gi...@git.apache.org>.
Github user lstav commented on the issue:
https://github.com/apache/accumulo/pull/198
Closing since the changes on this pull request are in #200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #198: Accumulo 4061
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/198
> It would be interesting to see and try to write a test for it. I would appreciate if you point me in the right direction.
You've had a little bit of experience here, seeing what Thrift generates and how to implement the server-side interface.
At a high level, think about the Accumulo Java 'Public API' is a wrapper around the Thrift RPCs. Client-side, we also have the Thrift generated code. Typically, the public API call would call either `MasterClient.execute(..)`, `ServerClient.execute(..)`, or `ThriftUtil.getTServerClient(..)`. These calls are for Master RPCs, RPC to any TabletServer, or RPC to a specific TabletServer, specifically.
I would not worry about doing a low-level test case, instead, build some public API method and then write a test around that new method. I think adding a method to `InstanceOperations` makes the most sense here.
If we decide that we don't want to make a new public API call for this, using `MasterClient.execute` to invoke the `getMasterStats(..)` method. https://github.com/apache/accumulo/blob/e900e67425d950bd4c0c5288a6270d7b362ac458/core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java#L69-L74 is an example of how to invoke this method. Hopefully this will be very straightforward to do with any of the existing test classes that extend AccumuloClusterIT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #198: Accumulo 4061
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/198
> Yes, it'd be nice if the other services also had a status API (with a version).
+1.
Having a version for the Master RPC would also be good.
Have you thought about trying to write a test for this? :) It would be a good adventure for you in using our lower-level RPC API calls to interact with Accumulo (instead of just the public API). Can point you in the right direction for examples if you're amenable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---