You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/29 16:59:00 UTC
[GitHub] [lucene] ChrisHegarty opened a new pull request #329: LUCENE-10132: Support addition of diagnostics by custom merge policies
ChrisHegarty opened a new pull request #329:
URL: https://github.com/apache/lucene/pull/329
# Description
It is currently not possible for custom merge policies to add additional diagnostics.
# Solution
Add a new method, `SegmentInfo::addDiagnostics`, that allows to add or modify the segment's diagnostics.
Alternatives:
- The new method could be constrained to simply "add", rather than "modify" (it could throw an exception if the given diagnostics map contains an entry with a key that is already present in the segment's diagnostics )
- We could avoid the new method completely and simply expose the existing `setDiagnostics`, by adding the public modifier.
On balance, the addition of the new `addDiagnostics` seems like a more cooperative way for custom merge policies to behave.
# Tests
An additional test scenarios, testAddDiagnostics, has been added that exercises the behaviour.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #329: LUCENE-10132: Support addition of diagnostics by custom merge policies
Posted by GitBox <gi...@apache.org>.
romseygeek merged pull request #329:
URL: https://github.com/apache/lucene/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org