[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #3: Hbase 22567

[GitBox <gi...@apache.org>]

busbey commented on a change in pull request #3: Hbase 22567
URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r292984174
 
 

 ##########
 File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
 ##########
 @@ -164,6 +171,86 @@ int setRegionState(String region, RegionState.State newState)
     return EXIT_FAILURE;
   }
 
+  int addMissingRegionsInMeta(String... tableNames) throws  IOException {
 
 Review comment:
   useful for backgound IMHO is git's "plumbing" vs "porcelain":
   
   https://git-scm.com/book/en/v2/Git-Internals-Plumbing-and-Porcelain
   
   analogous here would be "report missing" and "add region" as plumbing level. The output of either need not be user friendly and should focus on being maintainable. (so like encoded region name for the output of report missing would be fine)
   
   something like the wrapper Josh mentions would be a porcelain command, probably taking the encoded regions from report missing and providing a user friendly info (like table, region keys, etc). it'd be useful for it to have a `--dryrun` mode that skipped calling `add_region` so that operators could get the more user friendly version of info about what regions appear to be missing. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services