[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #235: Write to hdfs when local disk can't be write

[GitBox <gi...@apache.org>]

xianjingfeng commented on code in PR #235:
URL: https://github.com/apache/incubator-uniffle/pull/235#discussion_r980700382


##########
server/src/main/java/org/apache/uniffle/server/ShuffleDataFlushEvent.java:
##########
@@ -90,6 +92,14 @@ public ShuffleBuffer getShuffleBuffer() {
     return shuffleBuffer;
   }
 
+  public StorageManager getStorageManager() {

Review Comment:
   > It's a little weird that ShuffleDataFlushEvent have a member field `StorageManager`.
   
   `selectStorageManager` will be called again In `org.apache.uniffle.server.storage.MultiStorageManager#updateWriteMetrics`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org