You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2017/03/25 06:27:46 UTC
spark git commit: [HOTFIX][SQL] Fix the failed test cases in
GeneratorFunctionSuite
Repository: spark
Updated Branches:
refs/heads/master 0a6c50711 -> a2ce0a2e3
[HOTFIX][SQL] Fix the failed test cases in GeneratorFunctionSuite
### What changes were proposed in this pull request?
Multiple tests failed. Revert the changes on `supportCodegen` of `GenerateExec`. For example,
- https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75194/testReport/
### How was this patch tested?
N/A
Author: Xiao Li <ga...@gmail.com>
Closes #17425 from gatorsmile/turnOnCodeGenGenerateExec.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/a2ce0a2e
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/a2ce0a2e
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/a2ce0a2e
Branch: refs/heads/master
Commit: a2ce0a2e309e70d74ae5d2ed203f7919a0f79397
Parents: 0a6c507
Author: Xiao Li <ga...@gmail.com>
Authored: Fri Mar 24 23:27:42 2017 -0700
Committer: Xiao Li <ga...@gmail.com>
Committed: Fri Mar 24 23:27:42 2017 -0700
----------------------------------------------------------------------
.../org/apache/spark/sql/GeneratorFunctionSuite.scala | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/a2ce0a2e/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala
index b9871af..cef5bbf 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala
@@ -91,7 +91,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
val df = Seq((1, Seq(1, 2, 3)), (2, Seq())).toDF("a", "intList")
checkAnswer(
df.select(explode_outer('intList)),
- Row(1) :: Row(2) :: Row(3) :: Row(null) :: Nil)
+ Row(1) :: Row(2) :: Row(3) :: Nil)
}
test("single posexplode") {
@@ -105,7 +105,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
val df = Seq((1, Seq(1, 2, 3)), (2, Seq())).toDF("a", "intList")
checkAnswer(
df.select(posexplode_outer('intList)),
- Row(0, 1) :: Row(1, 2) :: Row(2, 3) :: Row(null, null) :: Nil)
+ Row(0, 1) :: Row(1, 2) :: Row(2, 3) :: Nil)
}
test("explode and other columns") {
@@ -161,7 +161,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
checkAnswer(
df.select(explode_outer('intList).as('int)).select('int),
- Row(1) :: Row(2) :: Row(3) :: Row(null) :: Nil)
+ Row(1) :: Row(2) :: Row(3) :: Nil)
checkAnswer(
df.select(explode('intList).as('int)).select(sum('int)),
@@ -182,7 +182,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
checkAnswer(
df.select(explode_outer('map)),
- Row("a", "b") :: Row(null, null) :: Row("c", "d") :: Nil)
+ Row("a", "b") :: Row("c", "d") :: Nil)
}
test("explode on map with aliases") {
@@ -198,7 +198,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
checkAnswer(
df.select(explode_outer('map).as("key1" :: "value1" :: Nil)).select("key1", "value1"),
- Row("a", "b") :: Row(null, null) :: Nil)
+ Row("a", "b") :: Nil)
}
test("self join explode") {
@@ -279,7 +279,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
)
checkAnswer(
df2.selectExpr("inline_outer(col1)"),
- Row(null, null) :: Row(3, "4") :: Row(5, "6") :: Nil
+ Row(3, "4") :: Row(5, "6") :: Nil
)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org