You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jeff Genender (JIRA)" <ji...@apache.org> on 2007/12/06 21:30:43 UTC

[jira] Closed: (GERONIMO-3615) AsyncHttpClient.sendRequest() should return a future

     [ https://issues.apache.org/jira/browse/GERONIMO-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Genender closed GERONIMO-3615.
-----------------------------------

    Resolution: Fixed

Never mind the last comment, I manually applied this patch, but the next one, if you could do a svn diff from the top directory, it will create the patch.  For adding java or new files, just do an svn add and teh diff will pick those up.  Thanks for the excellent patch!

> AsyncHttpClient.sendRequest() should return a future
> ----------------------------------------------------
>
>                 Key: GERONIMO-3615
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3615
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>         Attachments: patch.zip
>
>
> Currently the caller gets notified when the I/O is completed via AsyncHttpClientCallback.  While this works for many use cases, there may be situations where sendRequest() returning a future would lead to a much more straightforward programming model.  This will become much more powerful especially if one initiates requests to multiple URLs at once.
> I would request that sendRequest() return a future object on which one can query the status of the operation, and also obtain the result or an error case (exception or timeout) by calling methods on the future.  It is desirable to have the return type implement java.util.concurrent.Future.
> Furthermore, the implementation class of the Future could retain the reference to the callback.  Then one can have a consolidated and coherent mechanism of completion (callbacks firing as a result of future completion).
> In other words, the suggestion is to change the return type of sendRequest() from void to java.util.concurrent.Future<HttpResponseMessage>.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.