You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Udara Liyanage <ud...@wso2.com> on 2014/11/22 05:14:58 UTC
REST API refactoring
Hi,
I started refactoring Stratos REST API. In the process I have changed
resource URLs so the API looks more RESTfull. I did not commit the changes
to master branch since it will break UI and CLI.
Instead I committed to a new branch "rest-api-refact" which you can work on
re factoring work.
--
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897
Re: REST API refactoring
Posted by Imesh Gunaratne <im...@apache.org>.
Great work Shiro! Thanks for looking into this.
On Thu, Nov 27, 2014 at 3:48 PM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
> Hi Devs,
>
> The REST API refactoring is now on master. (commits
> 2242e2fc6083129e3f0e5b08707250f5b1648a44, 023900c4fdd7ba9b12a228b5bf619e77885a3f2f,
> 72c9d60433d9b196d67268e850e572fd81a9fd97,
> 6af9901141c9a89c44e76803b6cbdbb68561714c).
>
> The last commit consists of the changes that were required due to this
> refactoring on the cli component.
>
> The next task in this would be to refactor the return codes / return body.
>
> Thank you,
> Shiro
>
> On Tue, Nov 25, 2014 at 9:37 PM, Imesh Gunaratne <im...@apache.org> wrote:
>
>> Great work Shiro!
>>
>> On Tue, Nov 25, 2014 at 3:47 PM, Shiroshica Kulatilake <sh...@wso2.com>
>> wrote:
>>
>>>
>>> 1. Do we need to expose the method *updateKubernetesHost(KubernetesHost
>>> kubernetesHost)* via the REST api ?
>>>
>>
>> IMO we need to check the reason for maintaining Kubernetes host
>> information in Stratos.
>>
>> 2. The *getServiceClusters(String cartridgeType)* method has been marked
>>> deprecated - It is deprecated due to *getClustersOfCartridge( String
>>> cartridgeType)* - since this is a new release should we remove this
>>> completely ?
>>>
>>> May be we need to remove this.
>>
>>
>> --
>> Imesh Gunaratne
>>
>> Technical Lead, WSO2
>> Committer & PMC Member, Apache Stratos
>>
>
>
>
> --
> Shiroshica Kulatilake
>
> Architect,
> WSO2, Inc. http://wso2.com/
> Phone: +94 776523867
>
--
Imesh Gunaratne
Technical Lead, WSO2
Committer & PMC Member, Apache Stratos
Re: REST API refactoring
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
Hi Devs,
The REST API refactoring is now on master. (commits
2242e2fc6083129e3f0e5b08707250f5b1648a44,
023900c4fdd7ba9b12a228b5bf619e77885a3f2f,
72c9d60433d9b196d67268e850e572fd81a9fd97,
6af9901141c9a89c44e76803b6cbdbb68561714c).
The last commit consists of the changes that were required due to this
refactoring on the cli component.
The next task in this would be to refactor the return codes / return body.
Thank you,
Shiro
On Tue, Nov 25, 2014 at 9:37 PM, Imesh Gunaratne <im...@apache.org> wrote:
> Great work Shiro!
>
> On Tue, Nov 25, 2014 at 3:47 PM, Shiroshica Kulatilake <sh...@wso2.com>
> wrote:
>
>>
>> 1. Do we need to expose the method *updateKubernetesHost(KubernetesHost
>> kubernetesHost)* via the REST api ?
>>
>
> IMO we need to check the reason for maintaining Kubernetes host
> information in Stratos.
>
> 2. The *getServiceClusters(String cartridgeType)* method has been marked
>> deprecated - It is deprecated due to *getClustersOfCartridge( String
>> cartridgeType)* - since this is a new release should we remove this
>> completely ?
>>
>> May be we need to remove this.
>
>
> --
> Imesh Gunaratne
>
> Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>
--
Shiroshica Kulatilake
Architect,
WSO2, Inc. http://wso2.com/
Phone: +94 776523867
Re: REST API refactoring
Posted by Imesh Gunaratne <im...@apache.org>.
Great work Shiro!
On Tue, Nov 25, 2014 at 3:47 PM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
>
> 1. Do we need to expose the method *updateKubernetesHost(KubernetesHost
> kubernetesHost)* via the REST api ?
>
IMO we need to check the reason for maintaining Kubernetes host information
in Stratos.
2. The *getServiceClusters(String cartridgeType)* method has been marked
> deprecated - It is deprecated due to *getClustersOfCartridge( String
> cartridgeType)* - since this is a new release should we remove this
> completely ?
>
> May be we need to remove this.
--
Imesh Gunaratne
Technical Lead, WSO2
Committer & PMC Member, Apache Stratos
Re: REST API refactoring
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
It's there - no change to that method
On Tue, Nov 25, 2014 at 4:11 PM, Dakshika Jayathilaka <da...@wso2.com>
wrote:
> Seems @GET "/groups" is missing here..
>
> Regards,
>
> *Dakshika Jayathilaka*
> Software Engineer
> WSO2, Inc.
> lean.enterprise.middleware
> 0771100911
>
> On Tue, Nov 25, 2014 at 3:47 PM, Shiroshica Kulatilake <sh...@wso2.com>
> wrote:
>
>> Hi devs,
>>
>> I incorporated the refactoring done by Udara and also did a few more
>> modifications.
>>
>> diffs can be viewed at:
>> 1.
>> https://github.com/shirolk/stratos/commit/b2c16968242cd4b290764563119695e1ec504618
>> 2.
>> https://github.com/shirolk/stratos/commit/c45da1728465063e6c816f5f5763f8b5a6cc5415
>>
>> There are two more questions that need to be resolved.
>>
>> 1. Do we need to expose the method *updateKubernetesHost(KubernetesHost
>> kubernetesHost)* via the REST api ?
>>
>> 2. The *getServiceClusters(String cartridgeType)* method has been marked
>> deprecated - It is deprecated due to *getClustersOfCartridge( String
>> cartridgeType)* - since this is a new release should we remove this
>> completely ?
>>
>> These two methods are still available.
>>
>> In the meantime I will be propagating these fixes to the command line
>> component - *org.apache.stratos.cli*
>>
>> Thank you,
>> Shiro
>>
>> On Mon, Nov 24, 2014 at 11:38 AM, Nirmal Fernando <nirmal070125@gmail.com
>> > wrote:
>>
>>> Seems like none of the recent updates were synched.
>>>
>>> On Mon, Nov 24, 2014 at 6:37 AM, Shiroshica Kulatilake <sh...@wso2.com>
>>> wrote:
>>>
>>>> Hi Udara,
>>>>
>>>> The branch which you created can only be seen in
>>>> https://git-wip-us.apache.org/repos/asf?p=stratos.git and not in
>>>> https://github.com/apache/stratos/
>>>>
>>>> Would you be able to please check what's missing.
>>>>
>>>> Thank you,
>>>> Shiro
>>>>
>>>> On Sat, Nov 22, 2014 at 9:44 AM, Udara Liyanage <ud...@wso2.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I started refactoring Stratos REST API. In the process I have changed
>>>>> resource URLs so the API looks more RESTfull. I did not commit the changes
>>>>> to master branch since it will break UI and CLI.
>>>>> Instead I committed to a new branch "rest-api-refact" which you can
>>>>> work on re factoring work.
>>>>>
>>>>> --
>>>>>
>>>>> Udara Liyanage
>>>>> Software Engineer
>>>>> WSO2, Inc.: http://wso2.com
>>>>> lean. enterprise. middleware
>>>>>
>>>>> web: http://udaraliyanage.wordpress.com
>>>>> phone: +94 71 443 6897
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Shiroshica Kulatilake
>>>>
>>>> Architect,
>>>> WSO2, Inc. http://wso2.com/
>>>> Phone: +94 776523867
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>> Nirmal
>>>
>>> Nirmal Fernando.
>>> PPMC Member & Committer of Apache Stratos,
>>> Senior Software Engineer, WSO2 Inc.
>>>
>>> Blog: http://nirmalfdo.blogspot.com/
>>>
>>
>>
>>
>> --
>> Shiroshica Kulatilake
>>
>> Architect,
>> WSO2, Inc. http://wso2.com/
>> Phone: +94 776523867
>>
>
>
--
Shiroshica Kulatilake
Architect,
WSO2, Inc. http://wso2.com/
Phone: +94 776523867
Re: REST API refactoring
Posted by Dakshika Jayathilaka <da...@wso2.com>.
Seems @GET "/groups" is missing here..
Regards,
*Dakshika Jayathilaka*
Software Engineer
WSO2, Inc.
lean.enterprise.middleware
0771100911
On Tue, Nov 25, 2014 at 3:47 PM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
> Hi devs,
>
> I incorporated the refactoring done by Udara and also did a few more
> modifications.
>
> diffs can be viewed at:
> 1.
> https://github.com/shirolk/stratos/commit/b2c16968242cd4b290764563119695e1ec504618
> 2.
> https://github.com/shirolk/stratos/commit/c45da1728465063e6c816f5f5763f8b5a6cc5415
>
> There are two more questions that need to be resolved.
>
> 1. Do we need to expose the method *updateKubernetesHost(KubernetesHost
> kubernetesHost)* via the REST api ?
>
> 2. The *getServiceClusters(String cartridgeType)* method has been marked
> deprecated - It is deprecated due to *getClustersOfCartridge( String
> cartridgeType)* - since this is a new release should we remove this
> completely ?
>
> These two methods are still available.
>
> In the meantime I will be propagating these fixes to the command line
> component - *org.apache.stratos.cli*
>
> Thank you,
> Shiro
>
> On Mon, Nov 24, 2014 at 11:38 AM, Nirmal Fernando <ni...@gmail.com>
> wrote:
>
>> Seems like none of the recent updates were synched.
>>
>> On Mon, Nov 24, 2014 at 6:37 AM, Shiroshica Kulatilake <sh...@wso2.com>
>> wrote:
>>
>>> Hi Udara,
>>>
>>> The branch which you created can only be seen in
>>> https://git-wip-us.apache.org/repos/asf?p=stratos.git and not in
>>> https://github.com/apache/stratos/
>>>
>>> Would you be able to please check what's missing.
>>>
>>> Thank you,
>>> Shiro
>>>
>>> On Sat, Nov 22, 2014 at 9:44 AM, Udara Liyanage <ud...@wso2.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I started refactoring Stratos REST API. In the process I have changed
>>>> resource URLs so the API looks more RESTfull. I did not commit the changes
>>>> to master branch since it will break UI and CLI.
>>>> Instead I committed to a new branch "rest-api-refact" which you can
>>>> work on re factoring work.
>>>>
>>>> --
>>>>
>>>> Udara Liyanage
>>>> Software Engineer
>>>> WSO2, Inc.: http://wso2.com
>>>> lean. enterprise. middleware
>>>>
>>>> web: http://udaraliyanage.wordpress.com
>>>> phone: +94 71 443 6897
>>>>
>>>
>>>
>>>
>>> --
>>> Shiroshica Kulatilake
>>>
>>> Architect,
>>> WSO2, Inc. http://wso2.com/
>>> Phone: +94 776523867
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Shiroshica Kulatilake
>
> Architect,
> WSO2, Inc. http://wso2.com/
> Phone: +94 776523867
>
Re: REST API refactoring
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
Hi devs,
I incorporated the refactoring done by Udara and also did a few more
modifications.
diffs can be viewed at:
1.
https://github.com/shirolk/stratos/commit/b2c16968242cd4b290764563119695e1ec504618
2.
https://github.com/shirolk/stratos/commit/c45da1728465063e6c816f5f5763f8b5a6cc5415
There are two more questions that need to be resolved.
1. Do we need to expose the method *updateKubernetesHost(KubernetesHost
kubernetesHost)* via the REST api ?
2. The *getServiceClusters(String cartridgeType)* method has been marked
deprecated - It is deprecated due to *getClustersOfCartridge( String
cartridgeType)* - since this is a new release should we remove this
completely ?
These two methods are still available.
In the meantime I will be propagating these fixes to the command line
component - *org.apache.stratos.cli*
Thank you,
Shiro
On Mon, Nov 24, 2014 at 11:38 AM, Nirmal Fernando <ni...@gmail.com>
wrote:
> Seems like none of the recent updates were synched.
>
> On Mon, Nov 24, 2014 at 6:37 AM, Shiroshica Kulatilake <sh...@wso2.com>
> wrote:
>
>> Hi Udara,
>>
>> The branch which you created can only be seen in
>> https://git-wip-us.apache.org/repos/asf?p=stratos.git and not in
>> https://github.com/apache/stratos/
>>
>> Would you be able to please check what's missing.
>>
>> Thank you,
>> Shiro
>>
>> On Sat, Nov 22, 2014 at 9:44 AM, Udara Liyanage <ud...@wso2.com> wrote:
>>
>>> Hi,
>>>
>>> I started refactoring Stratos REST API. In the process I have changed
>>> resource URLs so the API looks more RESTfull. I did not commit the changes
>>> to master branch since it will break UI and CLI.
>>> Instead I committed to a new branch "rest-api-refact" which you can work
>>> on re factoring work.
>>>
>>> --
>>>
>>> Udara Liyanage
>>> Software Engineer
>>> WSO2, Inc.: http://wso2.com
>>> lean. enterprise. middleware
>>>
>>> web: http://udaraliyanage.wordpress.com
>>> phone: +94 71 443 6897
>>>
>>
>>
>>
>> --
>> Shiroshica Kulatilake
>>
>> Architect,
>> WSO2, Inc. http://wso2.com/
>> Phone: +94 776523867
>>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>
--
Shiroshica Kulatilake
Architect,
WSO2, Inc. http://wso2.com/
Phone: +94 776523867
Re: REST API refactoring
Posted by Nirmal Fernando <ni...@gmail.com>.
Seems like none of the recent updates were synched.
On Mon, Nov 24, 2014 at 6:37 AM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
> Hi Udara,
>
> The branch which you created can only be seen in
> https://git-wip-us.apache.org/repos/asf?p=stratos.git and not in
> https://github.com/apache/stratos/
>
> Would you be able to please check what's missing.
>
> Thank you,
> Shiro
>
> On Sat, Nov 22, 2014 at 9:44 AM, Udara Liyanage <ud...@wso2.com> wrote:
>
>> Hi,
>>
>> I started refactoring Stratos REST API. In the process I have changed
>> resource URLs so the API looks more RESTfull. I did not commit the changes
>> to master branch since it will break UI and CLI.
>> Instead I committed to a new branch "rest-api-refact" which you can work
>> on re factoring work.
>>
>> --
>>
>> Udara Liyanage
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean. enterprise. middleware
>>
>> web: http://udaraliyanage.wordpress.com
>> phone: +94 71 443 6897
>>
>
>
>
> --
> Shiroshica Kulatilake
>
> Architect,
> WSO2, Inc. http://wso2.com/
> Phone: +94 776523867
>
--
Best Regards,
Nirmal
Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.
Blog: http://nirmalfdo.blogspot.com/
Re: REST API refactoring
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
Hi Udara,
The branch which you created can only be seen in
https://git-wip-us.apache.org/repos/asf?p=stratos.git and not in
https://github.com/apache/stratos/
Would you be able to please check what's missing.
Thank you,
Shiro
On Sat, Nov 22, 2014 at 9:44 AM, Udara Liyanage <ud...@wso2.com> wrote:
> Hi,
>
> I started refactoring Stratos REST API. In the process I have changed
> resource URLs so the API looks more RESTfull. I did not commit the changes
> to master branch since it will break UI and CLI.
> Instead I committed to a new branch "rest-api-refact" which you can work
> on re factoring work.
>
> --
>
> Udara Liyanage
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
> phone: +94 71 443 6897
>
--
Shiroshica Kulatilake
Architect,
WSO2, Inc. http://wso2.com/
Phone: +94 776523867