You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/01/30 18:09:42 UTC

[GitHub] couchdb-fauxton pull request: ZeroClipboard: Don't rely on code lo...

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/254

    ZeroClipboard: Don't rely on code loading order

    Bake path to swf-file into release at build time and make it
    configurable for different environments.
    
    Relying on the synchronous `registerExtensions` for configuration
    is not reliable in an asynchronous bootstrapping application like
    Fauxton

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb-fauxton zeroclipboard-path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #254
    
----
commit cf7a413025f07a47233f0d4fa9b35f921539a865
Author: Robert Kowalski <ro...@apache.org>
Date:   2015-01-30T17:08:22Z

    ZeroClipboard: Don't rely on code loading order
    
    Bake path to swf-file into release at build time and make it
    configurable for different environments.
    
    Relying on the synchronous `registerExtensions` for configuration
    is not reliable in an asynchronous bootstrapping application like
    Fauxton

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: ZeroClipboard: Don't rely on code lo...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: ZeroClipboard: Don't rely on code lo...

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/254#issuecomment-72416437
  
    +1 nice work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: ZeroClipboard: Don't rely on code lo...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/254#issuecomment-72451980
  
    aww, shame on me, forgot to write a test! added it! it's green on my travis: https://travis-ci.org/robertkowalski/couchdb-fauxton/builds/49173231
    
    haven't found out why it takes so long for travis to rerun the PR for apache/fauxton...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: ZeroClipboard: Don't rely on code lo...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/254#issuecomment-72453093
  
    merged as 017319776b7fddf40febb3ef1ea22cc6f5fddeb9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---