You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2021/11/04 09:35:27 UTC

[GitHub] [incubator-brpc] zhangh43 opened a new issue #1595: 有支持Arena的计划吗

zhangh43 opened a new issue #1595:
URL: https://github.com/apache/incubator-brpc/issues/1595


   bprc现在无法兼容新版本的protobuf。protobuf不友好的引入了纯虚函数
   
   ```
   #google/protobuf/message.h
    Message* New(Arena* arena) const override = 0;
   ```
   brpc是否有支持这个feature的计划?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] zhangh43 commented on issue #1595: 有支持Arena的计划吗

Posted by GitBox <gi...@apache.org>.
zhangh43 commented on issue #1595:
URL: https://github.com/apache/incubator-brpc/issues/1595#issuecomment-963759911


   谢谢 @Yejy813  我可以workaround,主要想问下brpc的开发者,是否有支持新版本protobuf的计划。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] gydong commented on issue #1595: 有支持Arena的计划吗

Posted by GitBox <gi...@apache.org>.
gydong commented on issue #1595:
URL: https://github.com/apache/incubator-brpc/issues/1595#issuecomment-963849969


   之前我们做过实验,在框架层面支持 arena 所带来的性能提升很微弱,所以没有推进支持


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] Yejy813 edited a comment on issue #1595: 有支持Arena的计划吗

Posted by GitBox <gi...@apache.org>.
Yejy813 edited a comment on issue #1595:
URL: https://github.com/apache/incubator-brpc/issues/1595#issuecomment-963335558


   我也遇到了,看了下protobuf的提交记录,是今年九月份的一个commit: @399250367 改的,你把pb代码回退重编下吧,要不然用旧版本也行
   
   ![image](https://user-images.githubusercontent.com/29630278/140780483-dbad7a36-baa4-4ba6-9638-d744aa7a2d8d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] Yejy813 commented on issue #1595: 有支持Arena的计划吗

Posted by GitBox <gi...@apache.org>.
Yejy813 commented on issue #1595:
URL: https://github.com/apache/incubator-brpc/issues/1595#issuecomment-963335558


   我也遇到了,看了下protobuf的提交记录,是最新一个commit: @399250367 改的,你把pb代码回退重编下吧,要不然用旧版本也行
   
   ![image](https://user-images.githubusercontent.com/29630278/140780483-dbad7a36-baa4-4ba6-9638-d744aa7a2d8d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org