You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Aaron Kimball (JIRA)" <ji...@apache.org> on 2009/07/31 08:14:14 UTC

[jira] Created: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Rename "local" mysql import to "direct"
---------------------------------------

                 Key: MAPREDUCE-816
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
          Components: contrib/sqoop
            Reporter: Aaron Kimball
            Assignee: Aaron Kimball
            Priority: Minor


A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument "--local." The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, "--local" is a poor name for the flag. "--direct" is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737898#action_12737898 ] 

Hudson commented on MAPREDUCE-816:
----------------------------------

Integrated in Hadoop-Mapreduce-trunk #35 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/35/])
    

> Rename "local" mysql import to "direct"
> ---------------------------------------
>
>                 Key: MAPREDUCE-816
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-816.patch
>
>
> A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument {{--local.}} The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, {{--local}} is a poor name for the flag. {{--direct}} is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Posted by "Matei Zaharia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matei Zaharia updated MAPREDUCE-816:
------------------------------------

    Description: A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument {{--local.}} The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, {{--local}} is a poor name for the flag. {{--direct}} is more general and more descriptive. This should be used instead.  (was: A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument "--local." The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, "--local" is a poor name for the flag. "--direct" is more general and more descriptive. This should be used instead.)

> Rename "local" mysql import to "direct"
> ---------------------------------------
>
>                 Key: MAPREDUCE-816
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: MAPREDUCE-816.patch
>
>
> A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument {{--local.}} The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, {{--local}} is a poor name for the flag. {{--direct}} is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Posted by "Matei Zaharia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matei Zaharia updated MAPREDUCE-816:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
           Status: Resolved  (was: Patch Available)

I've committed this. Thanks Aaron!

> Rename "local" mysql import to "direct"
> ---------------------------------------
>
>                 Key: MAPREDUCE-816
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-816.patch
>
>
> A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument {{--local.}} The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, {{--local}} is a poor name for the flag. {{--direct}} is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Kimball updated MAPREDUCE-816:
------------------------------------

    Attachment: MAPREDUCE-816.patch

> Rename "local" mysql import to "direct"
> ---------------------------------------
>
>                 Key: MAPREDUCE-816
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: MAPREDUCE-816.patch
>
>
> A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument "--local." The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, "--local" is a poor name for the flag. "--direct" is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737431#action_12737431 ] 

Aaron Kimball commented on MAPREDUCE-816:
-----------------------------------------

Also, no new tests were added because this is a trivial variable/method/command-line argument renaming.

> Rename "local" mysql import to "direct"
> ---------------------------------------
>
>                 Key: MAPREDUCE-816
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: MAPREDUCE-816.patch
>
>
> A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument "--local." The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, "--local" is a poor name for the flag. "--direct" is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Posted by "Matei Zaharia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737436#action_12737436 ] 

Matei Zaharia commented on MAPREDUCE-816:
-----------------------------------------

+1 patch looks good.

> Rename "local" mysql import to "direct"
> ---------------------------------------
>
>                 Key: MAPREDUCE-816
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: MAPREDUCE-816.patch
>
>
> A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument {{--local.}} The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, {{--local}} is a poor name for the flag. {{--direct}} is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737429#action_12737429 ] 

Aaron Kimball commented on MAPREDUCE-816:
-----------------------------------------

:sigh:, could someone with edit rights please correct the "\-\-" to escape the dashes with backslashes in the description to avoid the strike-thru?

This patch adds the \-\-direct flag and deprecates \-\-local with a warning. Would appreciate it if this makes it into the 0.21 release. I ran all the unit tests (including the mysql ones) on my system and they all pass.


> Rename "local" mysql import to "direct"
> ---------------------------------------
>
>                 Key: MAPREDUCE-816
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: MAPREDUCE-816.patch
>
>
> A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument "--local." The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, "--local" is a poor name for the flag. "--direct" is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-816) Rename "local" mysql import to "direct"

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Kimball updated MAPREDUCE-816:
------------------------------------

    Status: Patch Available  (was: Open)

> Rename "local" mysql import to "direct"
> ---------------------------------------
>
>                 Key: MAPREDUCE-816
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-816
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: MAPREDUCE-816.patch
>
>
> A mysqldump-based fast path known as "local mode" is used in sqoop when users pass the argument "--local." The restriction that this only import from localhost was based on an implementation technique that was later abandoned in favor of a more general one, which can support remote hosts as well. Thus, "--local" is a poor name for the flag. "--direct" is more general and more descriptive. This should be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.