You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/08/01 09:59:10 UTC
[GitHub] [submarine] MortalHappiness opened a new pull request #693: SUBMARINE-957. Extract helm dependencies from submarine operator
MortalHappiness opened a new pull request #693:
URL: https://github.com/apache/submarine/pull/693
### What is this PR for?
Instead of installing helm dependencies in our operator, we should install these dependencies using helm CLI from outside. In this way, we do not need to maintain helm dependencies in our operator. This can help us develop the multi-tenant feature.
### What type of PR is it?
[Improvement]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-957
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] MortalHappiness commented on pull request #693: SUBMARINE-957. Extract helm dependencies from submarine operator
Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #693:
URL: https://github.com/apache/submarine/pull/693#issuecomment-894746868
@Kenchu123 I have updated the README. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kevin85421 commented on pull request #693: SUBMARINE-957. Extract helm dependencies from submarine operator
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #693:
URL: https://github.com/apache/submarine/pull/693#issuecomment-893328440
@Kenchu123 can you review this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] Kenchu123 commented on pull request #693: SUBMARINE-957. Extract helm dependencies from submarine operator
Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #693:
URL: https://github.com/apache/submarine/pull/693#issuecomment-894759069
@kevin85421 @MortalHappiness LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] Kenchu123 commented on pull request #693: SUBMARINE-957. Extract helm dependencies from submarine operator
Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #693:
URL: https://github.com/apache/submarine/pull/693#issuecomment-894668851
I have found out that the traefik service was `submarine-operator-traefik`, this may be the `fullName` setting in `charts/traefik/templates/_helpers.tpl`.
Maybe you should replace the `service/submarine-traefik` to `service/submarine-operator-traefik` in the `kubectl portfoword` in README?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #693: SUBMARINE-957. Extract helm dependencies from submarine operator
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #693:
URL: https://github.com/apache/submarine/pull/693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] Kenchu123 edited a comment on pull request #693: SUBMARINE-957. Extract helm dependencies from submarine operator
Posted by GitBox <gi...@apache.org>.
Kenchu123 edited a comment on pull request #693:
URL: https://github.com/apache/submarine/pull/693#issuecomment-894668851
@MortalHappiness I have found out that the traefik service was `submarine-operator-traefik`, this may be the `fullName` setting in `charts/traefik/templates/_helpers.tpl`.
Maybe you should replace the `service/submarine-traefik` to `service/submarine-operator-traefik` in the `kubectl portfoword` in README?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kevin85421 commented on pull request #693: SUBMARINE-957. Extract helm dependencies from submarine operator
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #693:
URL: https://github.com/apache/submarine/pull/693#issuecomment-893328440
@Kenchu123 can you review this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org