[GitHub] [mynewt-mcumgr] de-nordic commented on a change in pull request #115: Support for software update to Direct-XIP built applications

[GitBox <gi...@apache.org>]

de-nordic commented on a change in pull request #115:
URL: https://github.com/apache/mynewt-mcumgr/pull/115#discussion_r594168908



##########
File path: cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c
##########
@@ -400,6 +400,7 @@ int img_mgmt_impl_erase_if_needed(uint32_t off, uint32_t len)
 int
 img_mgmt_impl_swap_type(void)
 {
+#if !defined(CONFIG_IMG_MGMT_DIRECT_XIP)

Review comment:
       @sjanc In this mode application will run from the slot it has been uploaded to. The problem is that you could still set the "opposite" slot in pending mode which means it would not be possible to overwrite and the flag would never be lifted as in XIP mode it will not switch slots, example:
   0) let have app_v0.0.0 and app_v0.0.1
   1) the app_v0.0.0 is running
   2) set the "opposite" slot to pending
   3) try to upload app_v0.0.1, will fail
   4) reboot
   5) the app_v0.0.0 is running, the "opposite" slot is in pending state, it is not possible to overwrite it at this point anymore.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org