You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Stitcher (JIRA)" <ji...@apache.org> on 2016/11/04 20:16:58 UTC
[jira] [Commented] (PROTON-1330) Include the C sources in the
python source distribution
[ https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637552#comment-15637552 ]
Andrew Stitcher commented on PROTON-1330:
-----------------------------------------
As an additional (probably optional) aspect to this issue, I note that the list of files to compile from within the c source is hardcoded into the setup.py file.
This strikes me as bad! I recently discovered to my irritation that creating new directories and moving some files around in the proton tree made the tox tests fail and it took me a little time to figure out why.
I'd suggest that the same process that packages up the source tree for use in the pytoh installation either also packages up a list of the files to compile, OR omits all the files that are not supposed to be compiled. In any event it would be *much* better if rearranging the C source tree didn't involve changing anything in the python setup.
> Include the C sources in the python source distribution
> -------------------------------------------------------
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: 0.15.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by apache infrastructure maintainers. This will lead to failures when installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the necessary proton-c source files for inclusion in the python bindings package. Instead of fetching the necessary sources from apache, setup.py can simply build and install the proton library using the bundled sources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org