You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/20 10:13:33 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
MaxGekk opened a new pull request #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645
### What changes were proposed in this pull request?
- Output warnings for deprecated SQL configs in `SQLConf. setConfWithCheck()` and in `SQLConf. unsetConf()`
- Throw an exception for removed SQL configs in `SQLConf. setConfWithCheck()` when they set to non-default values
- Remove checking of deprecated and removed SQL configs from RuntimeConfig
### Why are the changes needed?
Currently, warnings/exceptions are printed only when a SQL config is set dynamically, for instance via `spark.conf.set()`. After the changes, removed/deprecated SQL configs will be checked when they set statically. For example:
```
$ bin/spark-shell --conf spark.sql.fromJsonForceNullableSchema=false
scala> spark.emptyDataFrame
java.lang.IllegalArgumentException: Error while instantiating 'org.apache.spark.sql.hive.HiveSessionStateBuilder':
...
Caused by: org.apache.spark.sql.AnalysisException: The SQL config 'spark.sql.fromJsonForceNullableSchema' was removed in the version 3.0.0. It was removed to prevent errors like SPARK-23173 for non-default value.
```
```
$ bin/spark-shell --conf spark.sql.hive.verifyPartitionPath=false
scala> spark.emptyDataFrame
20/02/20 02:10:26 WARN SQLConf: The SQL config 'spark.sql.hive.verifyPartitionPath' has been deprecated in Spark v3.0 and may be removed in the future. This config is replaced by 'spark.files.ignoreMissingFiles'.
```
### Does this PR introduce any user-facing change?
Yes
### How was this patch tested?
By `SQLConfSuite`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-589099039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118713/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-589099039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118713/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-588901384
**[Test build #118713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118713/testReport)** for PR 27645 at commit [`f00e4d1`](https://github.com/apache/spark/commit/f00e4d1add13cd1535860d20818470d9f9799c16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-589097770
**[Test build #118713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118713/testReport)** for PR 27645 at commit [`f00e4d1`](https://github.com/apache/spark/commit/f00e4d1add13cd1535860d20818470d9f9799c16).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-588903360
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-589099013
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-588901384
**[Test build #118713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118713/testReport)** for PR 27645 at commit [`f00e4d1`](https://github.com/apache/spark/commit/f00e4d1add13cd1535860d20818470d9f9799c16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-589099013
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-588903394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23464/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-588903394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23464/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-588903360
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27645:
[SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config
checks from RuntimeConfig to SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27645: [SPARK-29930][SPARK-30416][SQL][FOLLOWUP] Move deprecated/removed config checks from RuntimeConfig to SQLConf
URL: https://github.com/apache/spark/pull/27645#issuecomment-589154192
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org