You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/06/26 18:00:46 UTC
Review Request 12110: Cloudstack-3106 Delete all the ips except for the ip
alias.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Bugs: Cloudstack-3106
Repository: cloudstack-git
Description
-------
Cloudstack-3106 Delete all the ips except for the ip alias.
https://issues.apache.org/jira/browse/CLOUDSTACK-3106
Diffs
-----
engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33
Diff: https://reviews.apache.org/r/12110/diff/
Testing
-------
Tested on master.
Thanks,
bharat kumar
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the
ip alias.
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/#review22467
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On June 26, 2013, 4 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12110/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 4 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: Cloudstack-3106
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Cloudstack-3106 Delete all the ips except for the ip alias.
> https://issues.apache.org/jira/browse/CLOUDSTACK-3106
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33
>
> Diff: https://reviews.apache.org/r/12110/diff/
>
>
> Testing
> -------
>
> Tested on master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the
ip alias. Cloudstack-3119 Shared network removal doesn't cleanup
corresponding IP ranges
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/
-----------------------------------------------------------
(Updated June 28, 2013, 9:14 a.m.)
Review request for cloudstack and Abhinandan Prateek.
Summary (updated)
-----------------
Cloudstack-3106 Delete all the ips except for the ip alias. Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges
Bugs: Cloudstack-3106
Repository: cloudstack-git
Description (updated)
-------
Cloudstack-3106 Delete all the ips except for the ip alias.
https://issues.apache.org/jira/browse/CLOUDSTACK-3106
Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges
https://issues.apache.org/jira/browse/CLOUDSTACK-3119
Diffs
-----
engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc
engine/schema/src/com/cloud/network/dao/IPAddressDao.java fecd44a
engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 886011e
server/src/com/cloud/configuration/ConfigurationManagerImpl.java cb4f76b
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 4b29eab
Diff: https://reviews.apache.org/r/12110/diff/
Testing
-------
Tested on master.
Thanks,
bharat kumar
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the
ip alias.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/
-----------------------------------------------------------
(Updated June 28, 2013, 9:13 a.m.)
Review request for cloudstack and Abhinandan Prateek.
Changes
-------
rebased with master-stable.
Bugs: Cloudstack-3106
Repository: cloudstack-git
Description
-------
Cloudstack-3106 Delete all the ips except for the ip alias.
https://issues.apache.org/jira/browse/CLOUDSTACK-3106
Diffs (updated)
-----
engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc
engine/schema/src/com/cloud/network/dao/IPAddressDao.java fecd44a
engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 886011e
server/src/com/cloud/configuration/ConfigurationManagerImpl.java cb4f76b
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 4b29eab
Diff: https://reviews.apache.org/r/12110/diff/
Testing
-------
Tested on master.
Thanks,
bharat kumar
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the
ip alias.
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/#review22494
-----------------------------------------------------------
1. Move txn code to method removeFromDB.
2. Rename removeFromDB to more meaningful name and possibly move it to vlanDAO
3. Don't suppress exceptions, use these to surface errors.
4. Don't use finally from txn.commit.
5. Check if you need to return values from your methods at several places or possibly eliminate these returns.
6. For checking conditions and the possibly acting on those donot use that many booleans.
- Abhinandan Prateek
On June 27, 2013, 10:57 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12110/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 10:57 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: Cloudstack-3106
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Cloudstack-3106 Delete all the ips except for the ip alias.
> https://issues.apache.org/jira/browse/CLOUDSTACK-3106
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/dc/VlanVO.java a2f7a9c
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 041f29a
>
> Diff: https://reviews.apache.org/r/12110/diff/
>
>
> Testing
> -------
>
> Tested on master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the
ip alias.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/
-----------------------------------------------------------
(Updated June 27, 2013, 10:57 a.m.)
Review request for cloudstack and Abhinandan Prateek.
Changes
-------
rebased with master.
Bugs: Cloudstack-3106
Repository: cloudstack-git
Description
-------
Cloudstack-3106 Delete all the ips except for the ip alias.
https://issues.apache.org/jira/browse/CLOUDSTACK-3106
Diffs (updated)
-----
engine/schema/src/com/cloud/dc/VlanVO.java a2f7a9c
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 041f29a
Diff: https://reviews.apache.org/r/12110/diff/
Testing
-------
Tested on master.
Thanks,
bharat kumar
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the
ip alias.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/
-----------------------------------------------------------
(Updated June 27, 2013, 10:56 a.m.)
Review request for cloudstack and Abhinandan Prateek.
Changes
-------
rebased with master-stable.
Bugs: Cloudstack-3106
Repository: cloudstack-git
Description
-------
Cloudstack-3106 Delete all the ips except for the ip alias.
https://issues.apache.org/jira/browse/CLOUDSTACK-3106
Diffs (updated)
-----
engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc
server/src/com/cloud/configuration/ConfigurationManagerImpl.java cb4f76b
Diff: https://reviews.apache.org/r/12110/diff/
Testing
-------
Tested on master.
Thanks,
bharat kumar