You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/21 16:48:00 UTC

[jira] [Commented] (RYA-346) Remove Duplicate RyaExportITBase

    [ https://issues.apache.org/jira/browse/RYA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135416#comment-16135416 ] 

ASF GitHub Bot commented on RYA-346:
------------------------------------

GitHub user meiercaleb opened a pull request:

    https://github.com/apache/incubator-rya/pull/210

    RYA-346-Removed duplicate RyaExportIT and fixed failing GeoFunctionsIT

    tests.
    
    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    Removed a duplicate RyaExportIT in the rya.pcj.geo.functions project.  This project now utilizes the test base project.  This fixed broken tests in GeoFunctionsIT that were using the duplicate version of RyaExportIT, which was not re-configured to use changes to the Fluo Observer framework that were committed in an earlier PR.  
    
    ### Tests
    GeoFunctionsIT.
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-346)
    
    ### Checklist
    - [ ] Code Review
    - [x] Squash Commits
    
    #### People To Reivew
    @pujav65 @amihalik @ejwhite922 @isper3at 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/meiercaleb/incubator-rya RYA-346

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #210
    
----
commit 98ba8850f8169f13a6455ff6590d52fd8901b5e4
Author: Caleb Meier <ca...@parsons.com>
Date:   2017-08-21T16:36:03Z

    RYA-346-Removed duplicate RyaExportIT and fixed failing GeoFunctionsIT
    tests.

----


> Remove Duplicate RyaExportITBase
> --------------------------------
>
>                 Key: RYA-346
>                 URL: https://issues.apache.org/jira/browse/RYA-346
>             Project: Rya
>          Issue Type: Bug
>    Affects Versions: 3.2.11
>            Reporter: Caleb Meier
>            Assignee: Caleb Meier
>
> The project rya.pcj.functions.geo has a duplicate version of RyaExportITBase, which was originally created because the original RyaExportITBase was not included in a test project.  Now that a test project exists, rya.pcj.functions.geo needs to be updated to use that dependency.  This will fix the broken tests found in GeoFunctionsIT in rya.pcj.functions.geo.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)