You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Arjun Mishra via Review Board <no...@reviews.apache.org> on 2018/05/17 15:19:33 UTC

Review Request 67186: HIVE-19585: Add UNKNOWN to PrincipalType

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67186/
-----------------------------------------------------------

Review request for hive and Sergio Pena.


Repository: hive-git


Description
-------

We need to include type UNKNOWN to PrincipalType to match with HivePrincipal.HivePrincipalType.UKNOWN


Diffs
-----

  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalType.java 82eb8fd700 


Diff: https://reviews.apache.org/r/67186/diff/1/


Testing
-------


Thanks,

Arjun Mishra

Re: Review Request 67186: HIVE-19585: Add UNKNOWN to PrincipalType

Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.

> On May 17, 2018, 8:24 p.m., Sergio Pena wrote:
> > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalType.java
> > Lines 18 (patched)
> > <https://reviews.apache.org/r/67186/diff/1/?file=2024814#file2024814line18>
> >
> >     This file is auto-generated by Thrift. To add a new field, you need to edit the hive_metastore.thrift file and generate the new thrift files.
> >     
> >     Btw, this might add a behavior to all the authorization commands like: ALTER TABLE ... SET OWNER UNKNOWN <value>
> >     
> >     Do we want to support that? Do we need the UNKNOWN on the PrincipalType?

Good point about thrift file. 
Do we need to worry about adding new behavior? UNKNOWN is just the default type when no principal type is needed. 
We need the UNKNOWN on PrincipalType to match with HivePrincipal.HivePrincipalType


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67186/#review203369
-----------------------------------------------------------


On May 17, 2018, 3:19 p.m., Arjun Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67186/
> -----------------------------------------------------------
> 
> (Updated May 17, 2018, 3:19 p.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> We need to include type UNKNOWN to PrincipalType to match with HivePrincipal.HivePrincipalType.UKNOWN
> 
> 
> Diffs
> -----
> 
>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalType.java 82eb8fd700 
> 
> 
> Diff: https://reviews.apache.org/r/67186/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Re: Review Request 67186: HIVE-19585: Add UNKNOWN to PrincipalType

Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67186/#review203369
-----------------------------------------------------------




standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalType.java
Lines 18 (patched)
<https://reviews.apache.org/r/67186/#comment285539>

    This file is auto-generated by Thrift. To add a new field, you need to edit the hive_metastore.thrift file and generate the new thrift files.
    
    Btw, this might add a behavior to all the authorization commands like: ALTER TABLE ... SET OWNER UNKNOWN <value>
    
    Do we want to support that? Do we need the UNKNOWN on the PrincipalType?


- Sergio Pena


On May 17, 2018, 3:19 p.m., Arjun Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67186/
> -----------------------------------------------------------
> 
> (Updated May 17, 2018, 3:19 p.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> We need to include type UNKNOWN to PrincipalType to match with HivePrincipal.HivePrincipalType.UKNOWN
> 
> 
> Diffs
> -----
> 
>   standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalType.java 82eb8fd700 
> 
> 
> Diff: https://reviews.apache.org/r/67186/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>