You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mario-renau-alstom (via GitHub)" <gi...@apache.org> on 2023/08/08 15:29:25 UTC
[GitHub] [incubator-pekko-samples] mario-renau-alstom opened a new pull request, #61: Fixed some typos
mario-renau-alstom opened a new pull request, #61:
URL: https://github.com/apache/incubator-pekko-samples/pull/61
Fixed some typos in README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-samples] mario-renau-alstom commented on a diff in pull request #61: Fixed some typos
Posted by "mario-renau-alstom (via GitHub)" <gi...@apache.org>.
mario-renau-alstom commented on code in PR #61:
URL: https://github.com/apache/incubator-pekko-samples/pull/61#discussion_r1287962799
##########
pekko-sample-distributed-workers-scala/README.md:
##########
@@ -76,7 +76,7 @@ The `FrontEnd` actor schedules `Tick` messages to itself when starting up. the `
The cluster contains one `WorkManager` actor. The `FrontEnd` actor does not need to know the exact location because it sends work to the `masterProxy` that is a cluster singleton proxy.
-The 'WorkManager' actor can accept or deny a work request and we need to deal with unexpected errors:
+The 'WorkManager' actor can accept or deny a work request, and we need to deal with unexpected errors:
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-samples] pjfanning merged pull request #61: Fixed some typos
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #61:
URL: https://github.com/apache/incubator-pekko-samples/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-samples] pjfanning commented on a diff in pull request #61: Fixed some typos
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #61:
URL: https://github.com/apache/incubator-pekko-samples/pull/61#discussion_r1287431673
##########
pekko-sample-distributed-workers-scala/README.md:
##########
@@ -76,7 +76,7 @@ The `FrontEnd` actor schedules `Tick` messages to itself when starting up. the `
The cluster contains one `WorkManager` actor. The `FrontEnd` actor does not need to know the exact location because it sends work to the `masterProxy` that is a cluster singleton proxy.
-The 'WorkManager' actor can accept or deny a work request and we need to deal with unexpected errors:
+The 'WorkManager' actor can accept or deny a work request, and we need to deal with unexpected errors:
Review Comment:
I don't think it is the norm to add a comma before 'and'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org