You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2009/06/30 03:24:47 UTC

[jira] Created: (HIVE-593) UDF and GenericUDF clean-up

UDF and GenericUDF clean-up
---------------------------

                 Key: HIVE-593
                 URL: https://issues.apache.org/jira/browse/HIVE-593
             Project: Hadoop Hive
          Issue Type: Improvement
    Affects Versions: 0.3.0, 0.3.1
            Reporter: Zheng Shao


We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-593) UDF and GenericUDF clean-up

Posted by "Yongqiang He (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726466#action_12726466 ] 

Yongqiang He commented on HIVE-593:
-----------------------------------

there is one error in line 97 of GenericUDFIndex, isWritable is not defined.

> UDF and GenericUDF clean-up
> ---------------------------
>
>                 Key: HIVE-593
>                 URL: https://issues.apache.org/jira/browse/HIVE-593
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.3.0, 0.3.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-593.1.patch
>
>
> We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
> We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HIVE-593) UDF and GenericUDF clean-up

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao reassigned HIVE-593:
-------------------------------

    Assignee: Zheng Shao

> UDF and GenericUDF clean-up
> ---------------------------
>
>                 Key: HIVE-593
>                 URL: https://issues.apache.org/jira/browse/HIVE-593
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.3.0, 0.3.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>
> We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
> We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-593) UDF and GenericUDF clean-up

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Chakka updated HIVE-593:
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.4.0
           Status: Resolved  (was: Patch Available)

Thanks Zheng.

> UDF and GenericUDF clean-up
> ---------------------------
>
>                 Key: HIVE-593
>                 URL: https://issues.apache.org/jira/browse/HIVE-593
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.3.0, 0.3.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.4.0
>
>         Attachments: HIVE-593.1.patch, HIVE-593.2.patch
>
>
> We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
> We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-593) UDF and GenericUDF clean-up

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-593:
----------------------------

    Attachment: HIVE-593.2.patch

Updated with trunk and fixed the problem.

> UDF and GenericUDF clean-up
> ---------------------------
>
>                 Key: HIVE-593
>                 URL: https://issues.apache.org/jira/browse/HIVE-593
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.3.0, 0.3.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-593.1.patch, HIVE-593.2.patch
>
>
> We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
> We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-593) UDF and GenericUDF clean-up

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726702#action_12726702 ] 

Prasad Chakka commented on HIVE-593:
------------------------------------

looks good. submit once tests are passed.

> UDF and GenericUDF clean-up
> ---------------------------
>
>                 Key: HIVE-593
>                 URL: https://issues.apache.org/jira/browse/HIVE-593
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.3.0, 0.3.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-593.1.patch, HIVE-593.2.patch
>
>
> We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
> We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-593) UDF and GenericUDF clean-up

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-593:
----------------------------

    Attachment: HIVE-593.1.patch

This patch replaces exprNodeIndexDesc and exprNodeIndexEvaluator with GenericUDF "index".

The removal of exprNodeFieldDesc will require some additional work (mainly that we need to serialize the field name together with the GenericUDF, but currently, GenericUDF is not serializable). I think we should move that to a separate JIRA, in which we will make GenericUDF optional implement Serializable, so that we can store compile-time information for use at the runtime.


> UDF and GenericUDF clean-up
> ---------------------------
>
>                 Key: HIVE-593
>                 URL: https://issues.apache.org/jira/browse/HIVE-593
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.3.0, 0.3.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-593.1.patch
>
>
> We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
> We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-593) UDF and GenericUDF clean-up

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-593:
----------------------------

    Status: Patch Available  (was: Open)

> UDF and GenericUDF clean-up
> ---------------------------
>
>                 Key: HIVE-593
>                 URL: https://issues.apache.org/jira/browse/HIVE-593
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.3.0, 0.3.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-593.1.patch
>
>
> We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
> We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.