You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/05/10 18:08:10 UTC
Review Request 59150: Document
LIBPROCESS_REQUIRE_PEER_ADDRESS_IP_MATCH.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59150/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7401
https://issues.apache.org/jira/browse/MESOS-7401
Repository: mesos
Description
-------
Document LIBPROCESS_REQUIRE_PEER_ADDRESS_IP_MATCH.
Diffs
-----
docs/configuration.md c5194e7566c13514f55742aa7278e75314f69d9c
Diff: https://reviews.apache.org/r/59150/diff/1/
Testing
-------
None.
Thanks,
James Peach
Re: Review Request 59150: Document
LIBPROCESS_REQUIRE_PEER_ADDRESS_IP_MATCH.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59150/#review174752
-----------------------------------------------------------
Ship it!
docs/configuration.md
Lines 2121 (patched)
<https://reviews.apache.org/r/59150/#comment247969>
Should we also mention that it prevents the use of proxies as well?
- Benjamin Mahler
On May 10, 2017, 6:08 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59150/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 6:08 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7401
> https://issues.apache.org/jira/browse/MESOS-7401
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document LIBPROCESS_REQUIRE_PEER_ADDRESS_IP_MATCH.
>
>
> Diffs
> -----
>
> docs/configuration.md c5194e7566c13514f55742aa7278e75314f69d9c
>
>
> Diff: https://reviews.apache.org/r/59150/diff/2/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 59150: Document
LIBPROCESS_REQUIRE_PEER_ADDRESS_IP_MATCH.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59150/#review175315
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58977, 59341, 59342, 59343, 58928, 59344, 58224, 59150]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 10, 2017, 6:08 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59150/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 6:08 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7401
> https://issues.apache.org/jira/browse/MESOS-7401
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document LIBPROCESS_REQUIRE_PEER_ADDRESS_IP_MATCH.
>
>
> Diffs
> -----
>
> docs/configuration.md c5194e7566c13514f55742aa7278e75314f69d9c
>
>
> Diff: https://reviews.apache.org/r/59150/diff/4/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>