[GitHub] [beam] udim commented on a change in pull request #14110: Add ListCoder distinct from IterableCoder.

[GitBox <gi...@apache.org>]

udim commented on a change in pull request #14110:
URL: https://github.com/apache/beam/pull/14110#discussion_r597325363



##########
File path: sdks/python/apache_beam/coders/coders.py
##########
@@ -1186,9 +1183,21 @@ def __hash__(self):
     return hash((type(self), self._elem_coder))
 
 
+class IterableCoder(ListLikeCoder):
+  """Coder of iterables of homogeneous objects."""
+  def to_type_hint(self):
+    return typehints.Iterable[self._elem_coder.to_type_hint()]
+
+
 Coder.register_structured_urn(common_urns.coders.ITERABLE.urn, IterableCoder)
 
 
+class ListCoder(ListLikeCoder):

Review comment:
       Should this be added to `__all__`?

##########
File path: sdks/python/apache_beam/coders/coders.py
##########
@@ -1131,7 +1131,7 @@ def __hash__(self):
     return hash((type(self), self._elem_coder))
 
 
-class IterableCoder(FastCoder):
+class ListLikeCoder(FastCoder):

Review comment:
       For the pydoc error, I'm not sure what's going on. Adding `apache_beam.coders.coders.ListLikeCoder` to ignore_identifiers in generate_pydoc.sh makes the problem go away.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org