You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/02/08 20:14:33 UTC

[GitHub] flink pull request: [FLINK-3355] [rocksdb backend] Allow passing o...

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/1608

    [FLINK-3355] [rocksdb backend] Allow passing options to the RocksDB backend

    This introduces an `OptionsFactory` to lazily create RocksDB Options and uses those to initialize the
    RocksDB instance.
    
    Tests: The necessary flag `setCreateIfMissing(true)` is defined on the options as part of the lazy creation of the RocksDB options. That way, it doubles as a test that the options are actually passed to the `AbstractRocksDBState`.
    
    At the moment, this does not persist the options factory with the checkpoint, but uses upon restore the same factory that is defined on the state backend. We have to check if that may cause issues with safepoints.
    
    Note: This also cleans up the generics in the RocksDB state classes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink rocks_options

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1608.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1608
    
----
commit 5a7112978164fad896a6c48b2e0e6215172df963
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-08T18:55:29Z

    [FLINK-3355] [rocksdb backend] Allow passing options to the RocksDB backend.
    
    This also cleans up the generics in the RocksDB state classes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3355] [rocksdb backend] Allow passing o...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1608


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3355] [rocksdb backend] Allow passing o...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1608#issuecomment-181807481
  
    :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3355] [rocksdb backend] Allow passing o...

Posted by gyfora <gi...@git.apache.org>.

Github user gyfora commented on the pull request:

    https://github.com/apache/flink/pull/1608#issuecomment-181800676
  
    Looks good :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---