[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to BaseGroupingSets

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #32073:
URL: https://github.com/apache/spark/pull/32073#discussion_r608423767



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala
##########
@@ -26,14 +26,14 @@ import org.apache.spark.sql.types._
 /**
  * A placeholder expression for cube/rollup, which will be replaced by analyzer
  */
-trait GroupingSet extends Expression with CodegenFallback {
+trait BaseGroupingSets extends Expression with CodegenFallback {
 
   def groupingSets: Seq[Seq[Expression]]
   def selectedGroupByExprs: Seq[Seq[Expression]]
 
   def groupByExprs: Seq[Expression] = {
     assert(children.forall(_.resolved),
-      "Cannot call GroupingSet.groupByExprs before the children expressions are all resolved.")
+      "Cannot call GroupingAnalytic.groupByExprs before the children expressions are all resolved.")

Review comment:
       > BaseGroupingSets
   
   Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org