You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Steve Gill (JIRA)" <ji...@apache.org> on 2017/08/17 18:55:00 UTC

[jira] [Commented] (CB-13185) cordova-labs-local-webserver hooks don't work on cordova cli 7

    [ https://issues.apache.org/jira/browse/CB-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131003#comment-16131003 ] 

Steve Gill commented on CB-13185:
---------------------------------

I think it is worth looking in cordova-lib to review the config.xml writing knowledge. after_plugin_install hook writing to config.xml seems like a usecase we want to support IMO

> cordova-labs-local-webserver hooks don't work on cordova cli 7
> --------------------------------------------------------------
>
>                 Key: CB-13185
>                 URL: https://issues.apache.org/jira/browse/CB-13185
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-wkwebview-engine
>    Affects Versions: cordova@7.0.0
>            Reporter: Pieter De Bruyne
>            Assignee: Shazron Abdullah
>            Priority: Critical
>              Labels: backlog, tools-next
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> cordova-labs-local-webserver modifies the config.xml using the after_plugin_install hook.
> however it appears cordova prepare restores the config.xml so the changes done by the hook are undone.
> Maybe before_prepare hook is a better idea ...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org