You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by kl0u <gi...@git.apache.org> on 2016/07/20 15:10:16 UTC
[GitHub] flink pull request #2270: [FLINK-3956] Make FileInputFormats independent fro...
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2270
[FLINK-3956] Make FileInputFormats independent from Configuration
This PR makes all the parameters from the input formats accessible through setters.
Before, some could only be set through a configuration object that was passed in the
`configure()` method. This was problematic because in streaming, this configuration
object is overwritten by a new configuration object with the default values, as it travels
from the client to the task managers, leading to parameters like the
`enumerateNestedFiles` flag in the `FileInputFormat` not being able to be set to a
non-default value.
NOTE: Now, values set by the setters overwrite the ones in the configuration.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink if_config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2270
----
commit e7ad5fdb32842036d5b1366132d95bd6db764942
Author: kl0u <kk...@gmail.com>
Date: 2016-07-18T16:18:43Z
[FLINK-3956] Make FileInputFormats independent from Configuration
Parameters of some input formats that was only possible to be
set through the Configuration object now have setter methods
that allow the user to do so.
Values set by the setters cannot be reset by the configuration
object.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2270: [FLINK-3956] Make FileInputFormats independent from Confi...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2270
Merged it. Could you please close this PR and mark the Jira as resolved?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2270: [FLINK-3956] Make FileInputFormats independent fro...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2270: [FLINK-3956] Make FileInputFormats independent from Confi...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2270
Perfect! I'll merge right away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2270: [FLINK-3956] Make FileInputFormats independent from Confi...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2270
Done! Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2270: [FLINK-3956] Make FileInputFormats independent from Confi...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2270
Thanks a lot @aljoscha !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---